-
-
Notifications
You must be signed in to change notification settings - Fork 46.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Transfer): fix transfer issue when trying to select item from the… #48664
Merged
li-jia-nan
merged 1 commit into
ant-design:master
from
andreyk1512:fix-transfer-unknown-target-key
Apr 26, 2024
Merged
fix(Transfer): fix transfer issue when trying to select item from the… #48664
li-jia-nan
merged 1 commit into
ant-design:master
from
andreyk1512:fix-transfer-unknown-target-key
Apr 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… right column while it has "unknown-key" within targetKeys
Run & review this pull request in StackBlitz Codeflow. |
👁 Visual Regression Report for PR #48664 Passed ✅
🎊 Congrats! No visual-regression diff found. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
li-jia-nan
approved these changes
Apr 26, 2024
The changelog ci check failed, and the test case is missing. 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… right column while it has "unknown-key" within targetKeys
中文版模板 / Chinese template
🤔 This is a ...
🔗 Related issue link
fix #48663
💡 Background and solution
To solve this I've added optional chaining when check 'disabled' property in 'item' object. It should help to filter empty items and avoid the issue.
📝 Changelog
☑️ Self-Check before Merge