Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: OTP with controlled of '' not working #48399

Merged
merged 2 commits into from
Apr 11, 2024
Merged

fix: OTP with controlled of '' not working #48399

merged 2 commits into from
Apr 11, 2024

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Apr 11, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix #48395

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Input.OTP controlled value to '' not work as expect.
🇨🇳 Chinese 修复 Input.OTP 组件受控设置 value'' 时不生效的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Apr 11, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Apr 11, 2024

👁 Visual Regression Report for PR #48399 Failed ❌

🎯 Target branch: master (f460b48)
📖 View Full Report ↗︎

Image name Expected Actual Diff
steps-label-placement.compact.css-var.png master: f460b48e8f9907b31448e7bca927e65814ec20e2 current: pr-48399 diff
steps-label-placement.dark.css-var.png master: f460b48e8f9907b31448e7bca927e65814ec20e2 current: pr-48399 diff
steps-label-placement.default.css-var.png master: f460b48e8f9907b31448e7bca927e65814ec20e2 current: pr-48399 diff
steps-progress-debug.dark.css-var.png master: f460b48e8f9907b31448e7bca927e65814ec20e2 current: pr-48399 diff
steps-progress.compact.css-var.png master: f460b48e8f9907b31448e7bca927e65814ec20e2 current: pr-48399 diff

Check Full Report for details

Copy link
Contributor

github-actions bot commented Apr 11, 2024

Preview is ready

Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 336.5 KB (+2 B 🔺)
./dist/antd-with-locales.min.js 383.48 KB (+48 B 🔺)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f460b48) to head (967696b).

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #48399   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          744       744           
  Lines        12866     12866           
  Branches      3365      3366    +1     
=========================================
  Hits         12866     12866           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zombieJ zombieJ merged commit 4216003 into master Apr 11, 2024
108 of 109 checks passed
@zombieJ zombieJ deleted the fix-otp branch April 11, 2024 07:24
@PeachScript PeachScript mentioned this pull request Apr 13, 2024
20 tasks
@teamco
Copy link

teamco commented May 19, 2024

It seems like there is also a validation problem:

e.g. If you fill in all the fields and then start erasing, then the validation does not work
error message not working as expected: {min, message: t(intl, 'form.validation.min', { entity, min })}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

主动setValue("")无效
4 participants