Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add inlineMargin token support form inline layout #48362

Merged
merged 4 commits into from
Apr 17, 2024

Conversation

CooperHash
Copy link
Contributor

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

#47590

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English add inlineMargin token
🇨🇳 Chinese 新增form inlineMarigin token

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Apr 9, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Apr 9, 2024

👁 Visual Regression Report for PR #48362 Passed ✅

🎯 Target branch: master (cd90120)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

Copy link
Contributor

github-actions bot commented Apr 9, 2024

Preview is ready

Copy link

codesandbox-ci bot commented Apr 9, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (cd90120) to head (dc1e7e9).

Additional details and impacted files
@@            Coverage Diff             @@
##            master    #48362    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          744       744            
  Lines        13426     12875   -551     
  Branches      3593      3366   -227     
==========================================
- Hits         13426     12875   -551     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CooperHash
Copy link
Contributor Author

@zombieJ take a look

btw:perview好像挂的很奇怪,跟pr的内容没有关系啊...

@afc163
Copy link
Member

afc163 commented Apr 16, 2024

新特性放 feature 分支吧。

@CooperHash CooperHash changed the base branch from master to feature April 16, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants