Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Alert support id and ref #48336

Merged
merged 3 commits into from
Apr 9, 2024
Merged

feat: Alert support id and ref #48336

merged 3 commits into from
Apr 9, 2024

Conversation

li-jia-nan
Copy link
Member

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English feat: Alert support id and ref
🇨🇳 Chinese feat: Alert 组件支持 id 和 ref

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Apr 8, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Apr 8, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Apr 8, 2024

👁 Visual Regression Report for PR #48336 Passed ✅

🎯 Target branch: feature (3062dc6)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

Copy link
Contributor

github-actions bot commented Apr 8, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 336.73 KB (+294 B 🔺)
./dist/antd-with-locales.min.js 383.55 KB (+44 B 🔺)

Copy link

codesandbox-ci bot commented Apr 8, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3062dc6) to head (9747496).

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #48336   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          743       743           
  Lines        12864     12865    +1     
  Branches      3371      3371           
=========================================
+ Hits         12864     12865    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

components/alert/Alert.tsx Outdated Show resolved Hide resolved
@li-jia-nan li-jia-nan requested a review from zombieJ April 8, 2024 14:09
afc163
afc163 previously approved these changes Apr 8, 2024
components/alert/index.ts Outdated Show resolved Hide resolved
@zombieJ zombieJ merged commit 4621bd9 into feature Apr 9, 2024
103 checks passed
@zombieJ zombieJ deleted the Alert-id-ref branch April 9, 2024 02:24
CooperHash pushed a commit to CooperHash/ant-design that referenced this pull request Apr 10, 2024
* feat: Alert support id and ref

* test: add test case

* chore: adjust ts def

---------

Co-authored-by: 二货机器人 <smith3816@gmail.com>
thinkasany pushed a commit to thinkasany/ant-design that referenced this pull request Apr 12, 2024
* feat: Alert support id and ref

* test: add test case

* chore: adjust ts def

---------

Co-authored-by: 二货机器人 <smith3816@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants