Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Tabs more props #48321

Merged
merged 13 commits into from
Apr 17, 2024
Merged

feat: add Tabs more props #48321

merged 13 commits into from
Apr 17, 2024

Conversation

CooperHash
Copy link
Contributor

@CooperHash CooperHash commented Apr 7, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

react-component/tabs#706
close #48085
close #44858
close #47507
close #44407

💡 Background and solution

目前,rc-tabs已经将moreIcon、moreTransitionName等合并为more

📝 Changelog

moreIcon、moreTransitionName combine to more Props

more: { icon, trigger} & dropdownProps
Language Changelog
🇺🇸 English Tabs support more={{ ... }} now.
🇨🇳 Chinese Tabs 新增 more={{ ... }} 属性以支持自定义下拉菜单的属性。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Apr 7, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Apr 7, 2024

👁 Visual Regression Report for PR #48321 Failed ❌

🎯 Target branch: feature (1092660)
📖 View Full Report ↗︎

Expected (Branch feature) Actual (Current PR) Diff
steps-label-placement.compact.png steps-label-placement.compact.png steps-label-placement.compact.png steps-label-placement.compact.png
steps-label-placement.compact.png steps-label-placement.compact.png steps-label-placement.compact.css-var.png steps-label-placement.compact.css-var.png
steps-label-placement.dark.png steps-label-placement.dark.png steps-label-placement.dark.png steps-label-placement.dark.png
steps-label-placement.dark.png steps-label-placement.dark.png steps-label-placement.dark.css-var.png steps-label-placement.dark.css-var.png
steps-label-placement.default.png steps-label-placement.default.png steps-label-placement.default.png steps-label-placement.default.png
steps-label-placement.default.png steps-label-placement.default.png steps-label-placement.default.css-var.png steps-label-placement.default.css-var.png
steps-progress-debug.dark.png steps-progress-debug.dark.png steps-progress-debug.dark.png steps-progress-debug.dark.png
steps-progress-debug.dark.png steps-progress-debug.dark.png steps-progress-debug.dark.css-var.png steps-progress-debug.dark.css-var.png
steps-progress.compact.png steps-progress.compact.png steps-progress.compact.png steps-progress.compact.png
steps-progress.compact.png steps-progress.compact.png steps-progress.compact.css-var.png steps-progress.compact.css-var.png

Check Full Report for details

Copy link
Contributor

github-actions bot commented Apr 7, 2024

Preview is ready

@afc163
Copy link
Member

afc163 commented Apr 7, 2024

feature branch

Copy link

socket-security bot commented Apr 7, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/rc-tabs@15.0.0 environment 0 166 kB afc163

🚮 Removed packages: npm/rc-tabs@14.1.1

View full report↗︎

Copy link

socket-security bot commented Apr 7, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

components/tabs/index.tsx Outdated Show resolved Hide resolved
Copy link

codesandbox-ci bot commented Apr 7, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Apr 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8a4a83a) to head (83dd2bd).

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #48321   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          744       744           
  Lines        12896     12896           
  Branches      3382      3382           
=========================================
  Hits         12896     12896           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CooperHash CooperHash changed the base branch from master to feature April 7, 2024 14:07
@CooperHash
Copy link
Contributor Author

CooperHash commented Apr 7, 2024

table 数量相对比较稳定,如果 PR 有新增,则应该更新这里快照)

image

md多了table该如何更新md整个页面的 snap

Copy link
Contributor

Hi @CooperHash. Thanks for your contribution. The path .github/ or scripts/ and CHANGELOG is only maintained by team members. This current PR will be closed and team members will help on this.

@github-actions github-actions bot closed this Apr 10, 2024
@CooperHash
Copy link
Contributor Author

update了tabs的snap,pr自动关了...

@CooperHash
Copy link
Contributor Author

update了tabs的snap,pr自动关了...

@afc163 要如何处理,不更新这个snap的话site test过不了

@afc163 afc163 reopened this Apr 10, 2024
@github-actions github-actions bot closed this Apr 10, 2024
@afc163 afc163 reopened this Apr 10, 2024
@CooperHash
Copy link
Contributor Author

md改回没有对齐的格式,git commit 自动format对齐

@CooperHash
Copy link
Contributor Author

md改回没有对齐的格式,git commit 自动format对齐

关掉husky commit了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants