Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Input.OTP support mask prop #48257

Merged
merged 24 commits into from
Apr 9, 2024
Merged

feat: Input.OTP support mask prop #48257

merged 24 commits into from
Apr 9, 2024

Conversation

li-jia-nan
Copy link
Member

@li-jia-nan li-jia-nan commented Apr 3, 2024 •
edited

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

image

📝 Changelog

Language Changelog
🇺🇸 English feat: Input.OTP support mask prop
🇨🇳 Chinese feat: Input.OTP 组件支持 mask 属性，显示自定义密文

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@stackblitz StackBlitz
Copy link

stackblitz bot commented Apr 3, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 3, 2024 •
edited

👁 Visual Regression Report for PR #48257 Failed ❌

🎯 Target branch: feature (4621bd9)
📖 View Full Report ↗︎

Image name Expected Actual Diff
input-otp.compact.png feature: 4621bd9f5ed1c66e70d6ef64de04a4565c1c4f46 current: pr-48257 diff
input-otp.compact.css-var.png feature: 4621bd9f5ed1c66e70d6ef64de04a4565c1c4f46 current: pr-48257 diff
input-otp.dark.png feature: 4621bd9f5ed1c66e70d6ef64de04a4565c1c4f46 current: pr-48257 diff
input-otp.dark.css-var.png feature: 4621bd9f5ed1c66e70d6ef64de04a4565c1c4f46 current: pr-48257 diff
input-otp.default.png feature: 4621bd9f5ed1c66e70d6ef64de04a4565c1c4f46 current: pr-48257 diff
input-otp.default.css-var.png feature: 4621bd9f5ed1c66e70d6ef64de04a4565c1c4f46 current: pr-48257 diff

Check Full Report for details

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 3, 2024 •
edited

Preview is ready

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 3, 2024 •
edited

size-limit report 📦

Path Size
./dist/antd.min.js 336.64 KB (-98 B 🔽)
./dist/antd-with-locales.min.js 383.56 KB (+14 B 🔺)

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Apr 3, 2024 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov Codecov
Copy link

codecov bot commented Apr 3, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3062dc6) to head (f6f9d8b).
Report is 1 commits behind head on feature.

Additional details and impacted files 
@@            Coverage Diff            @@
##           feature    #48257   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          743       743           
  Lines        12864     12926   +62     
  Branches      3371      3400   +29     
=========================================
+ Hits         12864     12926   +62

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@socket-security Socket Security
Copy link

socket-security bot commented Apr 4, 2024 •
edited

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

@li-jia-nan
Copy link
Member Author

li-jia-nan commented Apr 4, 2024 •
edited

@SocketSecurity ignore npm/fsevents@1.2.13
@SocketSecurity ignore npm/sharp@0.33.3
@SocketSecurity ignore npm/puppeteer@22.6.2
@SocketSecurity ignore npm/core-js-pure@3.36.1

@li-jia-nan li-jia-nan requested a review from yoyo837 April 4, 2024 16:23
@li-jia-nan
Copy link
Member Author

这 Size Limit 有点不太稳定，有时候能过，有时候不能过

@crazyair
Copy link
Member

crazyair commented Apr 7, 2024

直接自己再 useState 缓存一份 真实的 value 不行吗，搞这么复杂

@li-jia-nan li-jia-nan marked this pull request as draft April 8, 2024 07:16
@li-jia-nan li-jia-nan marked this pull request as ready for review April 8, 2024 11:21
@li-jia-nan li-jia-nan merged commit 53cbceb into feature Apr 9, 2024
102 of 103 checks passed
@li-jia-nan li-jia-nan deleted the OPT-mask branch April 9, 2024 06:47
CooperHash pushed a commit to CooperHash/ant-design that referenced this pull request Apr 10, 2024
@li-jia-nan @CooperHash
feat: Input.OTP support mask prop (ant-design#48257)
81bd7a9 
* feat: Input.OTP support mask prop

* fix: fix

* fix: fix

* test: add test case

* test: add test case

* chore: fix

* chore: update

* chore: remove

* chore: rename useOTPSingleValue

* fix: fix

* fix: fix

* chore: rm 3 lib

* chore: add 3 lib

* fix: fix

* fix: fix

* test: fix test case

* test: fix test case

* fix: fix

* fix: fix

---------

Signed-off-by: lijianan <574980606@qq.com>
thinkasany pushed a commit to thinkasany/ant-design that referenced this pull request Apr 12, 2024
@li-jia-nan @thinkasany
feat: Input.OTP support mask prop (ant-design#48257)
fc2d8de 
* feat: Input.OTP support mask prop

* fix: fix

* fix: fix

* test: add test case

* test: add test case

* chore: fix

* chore: update

* chore: remove

* chore: rename useOTPSingleValue

* fix: fix

* fix: fix

* chore: rm 3 lib

* chore: add 3 lib

* fix: fix

* fix: fix

* test: fix test case

* test: fix test case

* fix: fix

* fix: fix

---------

Signed-off-by: lijianan <574980606@qq.com>
@afc163 afc163 mentioned this pull request May 2, 2024
Merged
@rachid-abdoun-sien rachid-abdoun-sien mentioned this pull request May 24, 2024
Open
@nvmitsme nvmitsme mentioned this pull request May 24, 2024
Open
@tomlebl tomlebl mentioned this pull request May 25, 2024
Closed
@nvmitsme nvmitsme mentioned this pull request May 25, 2024
Open
@Kvanrooyen Kvanrooyen mentioned this pull request May 28, 2024
Open
@mholthausen mholthausen mentioned this pull request May 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zombieJ zombieJ zombieJ approved these changes

@yoyo837 yoyo837 Awaiting requested review from yoyo837

@afc163 afc163 Awaiting requested review from afc163

@MadCcc MadCcc Awaiting requested review from MadCcc

@crazyair crazyair Awaiting requested review from crazyair

@Wxh16144 Wxh16144 Awaiting requested review from Wxh16144

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@li-jia-nan @crazyair @afc163 @Wxh16144 @zombieJ @yoyo837 @MadCcc