feat: Support iconPosition with button icon #47791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
👁 Visual Regression Report for PR #47791 Passed ✅
🎊 Congrats! No visual-regression diff found. 
|
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
crazyair
reviewed
Mar 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature #47791 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 743 743
Lines 12853 12861 +8
Branches 3364 3370 +6
=========================================
+ Hits 12853 12861 +8 ☔ View full report in Codecov by Sentry. |
MadCcc
reviewed
Mar 11, 2024
MadCcc
reviewed
Mar 11, 2024
MadCcc
reviewed
Mar 11, 2024
afc163
reviewed
Mar 16, 2024
afc163
reviewed
Mar 16, 2024
afc163
reviewed
Mar 16, 2024
afc163
reviewed
Mar 16, 2024
afc163
reviewed
Mar 25, 2024
afc163
reviewed
Mar 25, 2024
afc163
reviewed
Mar 31, 2024
afc163
reviewed
Mar 31, 2024
afc163
reviewed
Mar 31, 2024
kiner-tang
reviewed
Mar 31, 2024
kiner-tang
reviewed
Mar 31, 2024
Co-authored-by: kiner-tang <1127031143@qq.com> Signed-off-by: George H <default_hyn@163.com>
Co-authored-by: kiner-tang <1127031143@qq.com> Signed-off-by: George H <default_hyn@163.com>
Co-authored-by: afc163 <afc163@gmail.com> Signed-off-by: George H <default_hyn@163.com>
Co-authored-by: afc163 <afc163@gmail.com> Signed-off-by: George H <default_hyn@163.com>
Co-authored-by: afc163 <afc163@gmail.com> Signed-off-by: George H <default_hyn@163.com>
afc163
approved these changes
Apr 7, 2024
|
🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR). 🎉 感谢您的贡献！如果您还没有加入钉钉社区群，请扫描下方二维码加入我们（加群时请提供此 PR 链接）。 
|
CooperHash
pushed a commit
to CooperHash/ant-design
that referenced
this pull request
Apr 10, 2024
* feat: button support iconPosition * fix: iconPosition compatible LoadingIcon * docs(Button): update Button with iconPosition demo * fix: delete debug type * fix: iconPosition for InnerLoadingIcon with not existIcon * chore: update button snapshots * fix: fixed loading-icon-end style * chore: refactor buttonContent with genButtonContent * fix: iconPosition compatible with rtl * docs(Button): update button with iconPosition demo * chore: update test * fix: iconPosition compatible with rtl * docs(Buttob): add icon-position demo * restore icon demo * update snapshots * docs: update icon button demo * docs: update iconPosition button demo * Update components/button/index.zh-CN.md Co-authored-by: kiner-tang <1127031143@qq.com> Signed-off-by: George H <default_hyn@163.com> * Update components/button/index.zh-CN.md Co-authored-by: kiner-tang <1127031143@qq.com> Signed-off-by: George H <default_hyn@163.com> * Update components/button/demo/icon-position.md Co-authored-by: afc163 <afc163@gmail.com> Signed-off-by: George H <default_hyn@163.com> * Update components/button/index.en-US.md Co-authored-by: afc163 <afc163@gmail.com> Signed-off-by: George H <default_hyn@163.com> * Update components/button/index.en-US.md Co-authored-by: afc163 <afc163@gmail.com> Signed-off-by: George H <default_hyn@163.com> --------- Signed-off-by: George H <default_hyn@163.com> Co-authored-by: kiner-tang <1127031143@qq.com> Co-authored-by: afc163 <afc163@gmail.com>
thinkasany
pushed a commit
to thinkasany/ant-design
that referenced
this pull request
Apr 12, 2024
* feat: button support iconPosition * fix: iconPosition compatible LoadingIcon * docs(Button): update Button with iconPosition demo * fix: delete debug type * fix: iconPosition for InnerLoadingIcon with not existIcon * chore: update button snapshots * fix: fixed loading-icon-end style * chore: refactor buttonContent with genButtonContent * fix: iconPosition compatible with rtl * docs(Button): update button with iconPosition demo * chore: update test * fix: iconPosition compatible with rtl * docs(Buttob): add icon-position demo * restore icon demo * update snapshots * docs: update icon button demo * docs: update iconPosition button demo * Update components/button/index.zh-CN.md Co-authored-by: kiner-tang <1127031143@qq.com> Signed-off-by: George H <default_hyn@163.com> * Update components/button/index.zh-CN.md Co-authored-by: kiner-tang <1127031143@qq.com> Signed-off-by: George H <default_hyn@163.com> * Update components/button/demo/icon-position.md Co-authored-by: afc163 <afc163@gmail.com> Signed-off-by: George H <default_hyn@163.com> * Update components/button/index.en-US.md Co-authored-by: afc163 <afc163@gmail.com> Signed-off-by: George H <default_hyn@163.com> * Update components/button/index.en-US.md Co-authored-by: afc163 <afc163@gmail.com> Signed-off-by: George H <default_hyn@163.com> --------- Signed-off-by: George H <default_hyn@163.com> Co-authored-by: kiner-tang <1127031143@qq.com> Co-authored-by: afc163 <afc163@gmail.com>
20 tasks
afc163
reviewed
May 8, 2024
| ); | ||
|
|
||
| const kids = | ||
| children || children === 0 ? spaceChildren(children, needInserted && autoInsertSpace) : null; | ||
|
|
||
| const genButtonContent = (iconComponent: React.ReactNode, kidsComponent: React.ReactNode) => { | ||
| const isRTL = direction === 'rtl'; | ||
| const iconFirst = (iconPosition === 'start' && !isRTL) || (iconPosition === 'end' && isRTL); |
There was a problem hiding this comment.
我昨天也纳闷，但是我爬楼发现这里评论了 #47791 (comment) CC @MadCcc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge