Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(steps): fix steps style #39103

Merged
merged 6 commits into from
Dec 1, 2022

Conversation

Wxh16144
Copy link
Member

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

ref: #39088

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English fix steps style
🇨🇳 Chinese 修复 Steps 组件样式

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Sorry, something went wrong.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 29, 2022

@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (047f0b3) compared to base (aa1945d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##           4.x-stable    #39103   +/-   ##
============================================
  Coverage      100.00%   100.00%           
============================================
  Files             447       447           
  Lines            8327      8327           
  Branches         2537      2537           
============================================
  Hits             8327      8327           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163 afc163 mentioned this pull request Nov 30, 2022
19 tasks
@afc163
Copy link
Member

afc163 commented Nov 30, 2022

图片

改完之后反而歪了。官网是下面这样的。

图片

@afc163
Copy link
Member

afc163 commented Nov 30, 2022

https://app.argos-ci.com/ant-design/ant-design/builds/3365/29968817 居然没测出来,不合理。

好像会漏 demo, @zombieJ @MadCcc @ant-design/ant-design-collaborators 这个得有人来看看。

@Wxh16144
Copy link
Member Author

Wxh16144 commented Nov 30, 2022

sorry,vertical 模式下没改到位,就关注图标去了。待会儿我补充一下, 5.x PR 里面也反馈了这个问题。

@@ -33,7 +33,7 @@
> .@{steps-prefix-cls}-item-tail {
position: absolute;
top: 0;
left: @steps-vertical-tail-width;
left: @steps-vertical-tail-width - 1; // line width
width: 1px;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@zombieJ
Copy link
Member

zombieJ commented Nov 30, 2022

好像会漏 demo, @zombieJ @MadCcc @ant-design/ant-design-collaborators 这个得有人来看看。

因为基线只有一个,它比较是 v5 的 Demo 全移走了,加了 v4 Demo:
截屏2022-11-30 21 35 30

@zombieJ
Copy link
Member

zombieJ commented Nov 30, 2022

我这边看起来也是改完了反而歪了:
截屏2022-11-30 21 36 55

截屏2022-11-30 21 36 42

@MadCcc MadCcc merged commit 1da8126 into ant-design:4.x-stable Dec 1, 2022
@afc163
Copy link
Member

afc163 commented Dec 4, 2022

@zombieJ 不对,就是会跳 demo。

截屏2022-12-04 17 49 17

@afc163 afc163 mentioned this pull request Dec 4, 2022
19 tasks
@zombieJ zombieJ mentioned this pull request Dec 5, 2022
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants