feat: add padding less variable for Alert #38369
Merged
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
🚨 Hi @ImOctopus. Thanks for your contribution, as the 🚨 你好，@ImOctopus。感谢你的贡献，由于 |
afc163
reviewed
Nov 3, 2022
components/style/themes/default.less
Outdated
| @@ -966,6 +966,8 @@ | |||
| @alert-text-color: @text-color; | |||
| @alert-close-color: @text-color-secondary; | |||
| @alert-close-hover-color: @icon-color-hover; | |||
| @alert-padding-vertical: @padding-xs; | |||
| @alert-padding-horizontal: 15px; | |||
There was a problem hiding this comment.
Suggested change
| @alert-padding-horizontal: 15px; | |
| @alert-padding-horizontal: @padding-sm - 1px; |
There was a problem hiding this comment.
看是15px，是不是应该@padding-md - 1px？
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #38369 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 446 446
Lines 8304 8304
Branches 2526 2526
=========================================
Hits 8304 8304 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
afc163
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
close: #38346
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge