-
-
Notifications
You must be signed in to change notification settings - Fork 51.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(typograph): add text field for Editconfig #37761
Conversation
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## feature #37761 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 444 444
Lines 8236 8238 +2
Branches 2439 2442 +3
=========================================
+ Hits 8236 8238 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
基于 feature branch |
提供一个 codesandbox ? |
切换到编辑模式,只能编辑去掉 suffix 的部分,实际场景更需要编辑状态下编辑完整的 text,切出编辑状态显示省略的点点点 |
rebase 要 push --force |
Merge 的 |
cb78e4d
to
8950fae
Compare
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
When we enable the ellipsis and editable features at the same time, the editing text implicitly uses the passed children as the editing content. As the ellipsis usage required, this children element(string type) should omit the suffix part and specify it to ellipsis, this causes when we enter the editing mode the value of the textarea has no this suffix part.
I think we could use the children as the showing content as the old way, and provide a config
text
to set the editing content explicitly. Then we can edit the full content of theTypograph
and see them with an ellipsis.📝 Changelog
text
config for editable Typograph, support enabling ellipsis and editable at the same timeTypograph
增加text
配置,支持同时开启省略与编辑模式时的使用☑️ Self-Check before Merge