-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing blacken docs #1750
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Done! Ready to merge! :) |
Codecov Report
@@ Coverage Diff @@
## main #1750 +/- ##
==========================================
- Coverage 85.56% 85.51% -0.05%
==========================================
Files 45 45
Lines 7660 7665 +5
==========================================
+ Hits 6554 6555 +1
- Misses 1106 1110 +4 |
@germa89 feel free to merge it whenever you want =) |
I was missing the badge.. Thank you @RobPasMue !! :) |
The workflow rules also had to be adapted to require the "pre-commit.ci - pr" stage instead of the "Code Style check" stage that you previously had. That was my other change =) Thanks for adding it to pre-commit.ci! |
This is awesome @germa89... look at the last two commits! I created a modification to make pre-commit fail... and all of a sudden, pre-commit.ci created a commit on my PR to solve the issues!! This is only possible for those hooks that have reformatting solutions implemented but it's definitely a great addition! |
Ohhh.. amazing.... #WhatATimeToBeAlive |
To fix the APDL sphinx lexer issues, I had to do some weird modification (basically wraps in single quotes everything that has a dot). The lexer should be improved by adding these changes after pygments/pygments#2314 is merged. |
Copying from ansys/pyansys-dev-guide#228