Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flobject.py #2148

Merged
merged 7 commits into from
Oct 17, 2023
Merged

Update flobject.py #2148

merged 7 commits into from
Oct 17, 2023

Conversation

hpohekar
Copy link
Collaborator

@hpohekar hpohekar commented Oct 17, 2023

Updated Optional[Union[str, List[str]]] -> Optional[Union[type, Tuple[type]]]

Fluent - !438324 (t921792)

Copy link
Member

@raph-luc raph-luc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Reminder to update this line as well (type or tuple of type):

attr_type_or_types : str or list of str, optional

@hpohekar
Copy link
Collaborator Author

Looks good to me. Reminder to update this line as well (type or tuple of types):

attr_type_or_types : str or list of str, optional

@raph-luc Done. Thank you.

@hpohekar hpohekar merged commit fa128dc into main Oct 17, 2023
@hpohekar hpohekar deleted the fix/update_flobject_1 branch October 17, 2023 14:43
raph-luc pushed a commit that referenced this pull request Oct 25, 2023
* Update flobject.py

* type fix

* StringType

* python type

* python type

* python type 1

* python type 2
raph-luc added a commit that referenced this pull request Oct 26, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* Fix vale warnings (#2139)

* fix tensor type for displacement variable (#2145)

* Fix set_state implementation for command argument instance. (#2147)

* Update flobject.py (#2148)

* SVAR Doc (#1635)

* Test to catch Watchdog launch errors, and improved Watchdog behavior on Windows (#2144)

* Cavitation Model Example And Example Warning Fix (#2102)

* Add type annotations for some modules under services (#2108)

* More robust Windows launch command for Watchdog (#2167)

* Making h5py an optional dependency, not installed by default (#2171)

* Expose settings root like in pyconsole. (#2149)

* Remove timeout loop in FluentConnection (#2126)

* Fix SVAR doc (#2172)

---------

Co-authored-by: Mainak Kundu <94432368+mkundu1@users.noreply.github.com>
Co-authored-by: Oleg Chernukhin <92750311+ochernuk@users.noreply.github.com>
Co-authored-by: Prithwish Mukherjee <109645853+prmukherj@users.noreply.github.com>
Co-authored-by: Harshal Pohekar <106588300+hpohekar@users.noreply.github.com>
Co-authored-by: Aseem Jain <95020968+ajain-work@users.noreply.github.com>
Co-authored-by: Prithwish Mukherjee <prithwish.mukherjee@ansys.com>
Co-authored-by: Adam Boutin <143635850+ansaboutin@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync the latest flobject.py between Fluent and PyFluent
3 participants