Raise an explicit error on plot_contour with empty mesh #2096
+103
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafacanton
approved these changes
Feb 18, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2096 +/- ##
==========================================
+ Coverage 86.60% 86.64% +0.04%
==========================================
Files 90 90
Lines 10250 10274 +24
==========================================
+ Hits 8877 8902 +25
+ Misses 1373 1372 -1 |
3 tasks
…_mesh # Conflicts: # tests/test_plotter.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #1718
PS: I will try and switch to the new plotter and deprecate this one soon, but in the meantime this makes the error clear.