Doc: improve static search speed and fix missing module icons #1971
+788
−787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
jorgepiloto
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Excellent, @moe-ad. I hope you used a script to automate this.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1971 +/- ##
==========================================
- Coverage 88.47% 88.37% -0.11%
==========================================
Files 89 89
Lines 10251 10251
==========================================
- Hits 9070 9059 -11
- Misses 1181 1192 +11 |
|
Yes. I used a python script for the task. |
|
No worries about the doc-style action. It fails for big diff PRs. |
PProfizi
reviewed
Jan 2, 2025
| @@ -1,6 +1,6 @@ | |||
| """ | |||
| elemental_difference | |||
| ==================== | |||
There was a problem hiding this comment.
Hi @moe-ad, everything under operators/ is generated automatically using a template. We'll need to update the template for this to stay that way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will close #1970. It adds html theme option to improve static search live preview performance. It also fixes the problem of missing module icons in the section navigation of the api documentation.