-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polygon operations added #4127
Polygon operations added #4127
Conversation
- move - rotate - scale
- move - rotate - scale
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4127 +/- ##
==========================================
+ Coverage 81.92% 81.93% +0.01%
==========================================
Files 182 182
Lines 63800 63846 +46
==========================================
+ Hits 52268 52313 +45
- Misses 11532 11533 +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job here, just a missing docstring description.
Btw, can't the scaling factor of scale
be an integer ?
Co-authored-by: SMoraisAnsys <146729917+SMoraisAnsys@users.noreply.github.com>
Co-authored-by: SMoraisAnsys <146729917+SMoraisAnsys@users.noreply.github.com>
Co-authored-by: SMoraisAnsys <146729917+SMoraisAnsys@users.noreply.github.com>
Co-authored-by: SMoraisAnsys <146729917+SMoraisAnsys@users.noreply.github.com>
Co-authored-by: SMoraisAnsys <146729917+SMoraisAnsys@users.noreply.github.com>
for more information, see https://pre-commit.ci
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
- move - rotate - scale
# Conflicts: # _unittest/test_00_EDB.py
Added:
polygon.move method
polygon.rotate method
polygon.scale method
polygon.move_layer method