Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: test action scripts using testing actions #47

Merged
merged 6 commits into from
Nov 10, 2022
Merged

Conversation

jorgepiloto
Copy link
Member

This pull-request introduces a testing job in the CI. It allows to test the different scripts collected in the scripts/ directory using the actions implemented in #42. This also has the advantage of testing the action itself.

@github-actions github-actions bot added the enhancement General improvements to existing features label Nov 8, 2022
@jorgepiloto jorgepiloto force-pushed the feat/test-scripts branch 3 times, most recently from 703a0f4 to 9e147af Compare November 9, 2022 10:08
@jorgepiloto
Copy link
Member Author

jorgepiloto commented Nov 9, 2022

I really like the new script for updating the versions.json file ❤️

@jorgepiloto
Copy link
Member Author

Still looking for a way to test this within our actions. The problem is that this is not a package but a script.

Verified

This commit was signed with the committer’s verified signature.
jorgepiloto Jorge Martínez

Verified

This commit was signed with the committer’s verified signature.
jorgepiloto Jorge Martínez
@github-actions github-actions bot added the maintenance Generic maintenance related label Nov 9, 2022
@jorgepiloto jorgepiloto force-pushed the feat/test-scripts branch 4 times, most recently from afa238c to 937d472 Compare November 9, 2022 15:37
@jorgepiloto jorgepiloto marked this pull request as ready for review November 9, 2022 15:37

Verified

This commit was signed with the committer’s verified signature.
jorgepiloto Jorge Martínez

Verified

This commit was signed with the committer’s verified signature.
jorgepiloto Jorge Martínez
@jorgepiloto jorgepiloto requested a review from a team November 9, 2022 17:01

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just did a minor change in one of the files since Vale was complaining

@jorgepiloto
Copy link
Member Author

Let me add one last change that @Revathyvenugopal162 asked for some days ago. That is having a "(stable)" not after the last stable release.

Verified

This commit was signed with the committer’s verified signature.
jorgepiloto Jorge Martínez
@jorgepiloto
Copy link
Member Author

Great! Now the script is able to add the X.Y (stable) tag to the latest stable release in the project in a dynamic way.

@jorgepiloto jorgepiloto merged commit d3ef4b2 into main Nov 10, 2022
@jorgepiloto jorgepiloto deleted the feat/test-scripts branch November 10, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement General improvements to existing features maintenance Generic maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants