feat: logging in windows environment #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
SMoraisAnsys
force-pushed
the
feat/logging-windows
branch
from
257f270
to
3f5cb1f
Compare
|
This worked with linux and windows github runners and a windows self-hosted runner used by pyaedt toolkits (see https://github.com/ansys/actions/actions/runs/8600801687/) |
jorgepiloto
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that a self-hosted runner recent enough, i.e. using windows 10, created without specific setup is able to use the
_loggingprivate action. Before it was only working if bash was included in PATH which is not the case for many self hosted runners.This will allow future actions dedicated to windows could use the _logging action without breaking changes.