Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow upper case in commit-style #447

Merged
merged 3 commits into from Apr 8, 2024

Conversation

SMoraisAnsys
Copy link
Contributor

As title says.

Closes #446

Note: option headerPattern seems to be related to "how to parse" a commit title to retrieve the type, scope and description. Thus it seems more adequate to use option types instead.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the enhancement New features or code improvements label Apr 8, 2024
@SMoraisAnsys SMoraisAnsys marked this pull request as ready for review April 8, 2024 07:45
@SMoraisAnsys SMoraisAnsys requested a review from a team as a code owner April 8, 2024 07:45
commit-style/action.yml Outdated Show resolved Hide resolved
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
Copy link
Contributor

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @SMoraisAnsys .

@SMoraisAnsys SMoraisAnsys merged commit e5b22f7 into main Apr 8, 2024
16 checks passed
@SMoraisAnsys SMoraisAnsys deleted the feat/allow-upper-case-in-pr-title branch April 8, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: extend commit-style to work with upper case
3 participants