Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: doc-changelog action infinite loop with pre-commit.ci #437

Merged
merged 7 commits into from Apr 1, 2024

Conversation

klmcadams
Copy link
Contributor

@klmcadams klmcadams commented Mar 29, 2024

Trailing whitespace in the title caused an infinite loop between the changelog action and pre-commit.ci fixing the fragment file by removing the trailing whitespace. This fix uses xargs to remove extra whitespace in the PR title

  1. Fragment file is added to the PR https://github.com/ansys/pymechanical/actions/runs/8483508864/job/23244782632?pr=669
  2. Merged in main & fragment file wasn't updated https://github.com/ansys/pymechanical/actions/runs/8483553847/job/23244904355?pr=669
  3. Title changed (still contains trailing whitespace) & fragment file updated: https://github.com/ansys/pymechanical/actions/runs/8483590918/job/23245005569?pr=669

Closes #436

@klmcadams klmcadams requested a review from a team as a code owner March 29, 2024 14:56
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Something isn't working label Mar 29, 2024
@RobPasMue
Copy link
Member

Seen this behaviour as well in PyAnsys Geometry...

@RobPasMue
Copy link
Member

I would strip trailing and leading whitespaces indeed... Seems like a cleaner solution

Copy link
Contributor

@dipinknair dipinknair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! fight between pyansys-ci-bot and pre-commit.ci ends here 😄

@RobPasMue RobPasMue merged commit 2f572de into main Apr 1, 2024
16 checks passed
@RobPasMue RobPasMue deleted the fix/doc-changelog-style-check branch April 1, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite loop if pre-commit fixes changelog fragment file
4 participants