Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: seo improvements #421

Merged
merged 38 commits into from Apr 17, 2024
Merged

feat: seo improvements #421

merged 38 commits into from Apr 17, 2024

Conversation

jorgepiloto
Copy link
Member

@jorgepiloto jorgepiloto commented Mar 12, 2024 •
edited

Warning

This is a testing branch used by PyAnsys Geometry. Do not merge.

Fix #284.

Changes in this pull-request focus on SEO improvements and include:

  • A new _doc-gen-robots action for creating an updating a robots.txt file
  • A script to ensure that a canonical tag exists in old version pages
  • Both version/stable/index.html and version/dev/index.html should point to landing page
  • Landing page should point to itself as the canonical
  • Complete sitemap with stable only pages
  • Ensure all refs point to main before merging! We will keep the branch after merging to avoid breaking PyAnsys Geometry CI/CD pipelines

jorgepiloto and others added 3 commits February 26, 2024 17:46
@jorgepiloto
feat: do not include sitemap.xml
14b13ea
@jorgepiloto @Revathyvenugopal162
fix: stop using redirect in favor of dev or stable index.html file (#415
868261a 
)

Co-authored-by: Revathy Venugopal <104772255+Revathyvenugopal162@users.noreply.github.com>
@jorgepiloto @RobPasMue @Revathyvenugopal162
feat: new _doc-gen-robots action to generate seo-compliant "robots.tx…
9b252fa 
…t" (#420)

Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
Co-authored-by: Revathy Venugopal <104772255+Revathyvenugopal162@users.noreply.github.com>
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the enhancement New features or code improvements label Mar 12, 2024
@jorgepiloto jorgepiloto added release Anything related to an incoming release blocked Cannot address this till other issues are solved first labels Mar 12, 2024
Revathyvenugopal162 and others added 4 commits March 12, 2024 10:08
@Revathyvenugopal162
Merge branch 'main' into feat/seo-improvements
a0c1413
@Revathyvenugopal162
Merge branch 'main' into feat/seo-improvements
0bbc679
@jorgepiloto @RobPasMue @Revathyvenugopal162
feat: new canonical link action (#425)
ab9cad7 
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
Co-authored-by: Revathy Venugopal <104772255+Revathyvenugopal162@users.noreply.github.com>
Co-authored-by: Revathyvenugopal162 <revathy.venugopal@ansys.com>
@jorgepiloto
Merge branch 'main' into feat/seo-improvements
b9be610
@wiz-inc-572fc38784
Copy link

wiz-inc-572fc38784 bot commented Mar 20, 2024 •
edited

Wiz Scan Summary
IaC Misconfigurations 0C 0H 0M 0L 0I
Vulnerabilities 0C 0H 0M 0L 0I
Sensitive Data 0C 0H 0M 0L 0I
Total 0C 0H 0M 0L 0I
Secrets 0🔑

@jorgepiloto
Copy link
Member Author

🐞 Bug The links to the canonical are not being substituted as expected, see the stable geometry pages.

@jorgepiloto jorgepiloto self-assigned this Apr 8, 2024
@jorgepiloto jorgepiloto marked this pull request as ready for review April 9, 2024 12:49
@jorgepiloto jorgepiloto requested a review from a team as a code owner April 9, 2024 12:49
RobPasMue
RobPasMue reviewed Apr 9, 2024
View reviewed changes
doc/source/conf.py Outdated Show resolved Hide resolved
RobPasMue
RobPasMue requested changes Apr 10, 2024
View reviewed changes
doc/source/migrations/index.rst Outdated Show resolved Hide resolved
@jorgepiloto
Copy link
Member Author

Somehow, the geometry.docs.pyansys.com ended up with various link tags for canonical. Let me investigate a bit more.

@jorgepiloto jorgepiloto marked this pull request as draft April 15, 2024 06:33
@jorgepiloto jorgepiloto marked this pull request as ready for review April 16, 2024 12:14
@jorgepiloto
Copy link
Member Author

Somehow, the geometry.docs.pyansys.com ended up with various link tags for canonical. Let me investigate a bit more.

This is finally fix.

@jorgepiloto jorgepiloto merged commit ba4b48e into main Apr 17, 2024
16 checks passed
@jorgepiloto jorgepiloto deleted the feat/seo-improvements branch April 17, 2024 07:20
@jorgepiloto jorgepiloto restored the feat/seo-improvements branch April 17, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Revathyvenugopal162 Revathyvenugopal162 Revathyvenugopal162 left review comments

@RobPasMue RobPasMue RobPasMue requested changes

Assignees

@jorgepiloto jorgepiloto

Labels
blocked Cannot address this till other issues are solved first enhancement New features or code improvements release Anything related to an incoming release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multi-version redirection link is killing pages indexing
3 participants
@jorgepiloto @RobPasMue @Revathyvenugopal162