Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update default vale version 3.4.1 #410

Merged
merged 17 commits into from Apr 16, 2024
Merged

chore: Update default vale version 3.4.1 #410

merged 17 commits into from Apr 16, 2024

Conversation

dipinknair
Copy link
Contributor

@dipinknair dipinknair commented Feb 23, 2024 •
edited

Update the default vale version to 3.4.1

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the maintenance Package and maintenance related label Feb 23, 2024
@dipinknair dipinknair changed the title MAINT: Update default vale version 3.1.0 chore: Update default vale version 3.1.0 Feb 23, 2024
@dipinknair
Copy link
Contributor Author

@ansys-reviewer-bot review

@ansys-reviewer-bot
Copy link
Contributor

Okay, I will trigger a review of your PR.

@jorgepiloto
Copy link
Member

jorgepiloto commented Feb 23, 2024 •
edited

Before merging this, can we check for #411?

@RobPasMue
Copy link
Member

I believe we should leave this PR unmerged until we decide to actually do a v6

@jorgepiloto
Copy link
Member

I see... That's a good point. Otherwise we may run into some v6 -> v7

@jorgepiloto jorgepiloto added release Anything related to an incoming release blocked Cannot address this till other issues are solved first labels Feb 23, 2024
@RobPasMue
Copy link
Member

@dipinknair - could you adapt the docs/source/migration_guide.rst file to reflect the changes needed to be done?

@dipinknair dipinknair mentioned this pull request Feb 23, 2024
Merged
@dipinknair dipinknair mentioned this pull request Feb 23, 2024
Merged
@Revathyvenugopal162
Copy link
Contributor

vale has upgraded to version "3.3.0," and everything seems fine. I think we can go straight to version 3.3 instead of considering version 3.1.

@RobPasMue
Copy link
Member

Sure :)

vale has upgraded to version "3.3.0," and everything seems fine. I think we can go straight to version 3.3 instead of considering version 3.1.

RobPasMue
RobPasMue reviewed Mar 14, 2024
View reviewed changes
doc-style/action.yml Outdated Show resolved Hide resolved
@RobPasMue RobPasMue changed the title chore: Update default vale version 3.1.0 chore: Update default vale version 3.3.0 Mar 14, 2024
@wiz-inc-572fc38784
Copy link

wiz-inc-572fc38784 bot commented Mar 14, 2024 •
edited

Wiz Scan Summary
IaC Misconfigurations 0C 0H 0M 0L 0I
Vulnerabilities 0C 0H 0M 0L 0I
Sensitive Data 0C 0H 0M 0L 0I
Total 0C 0H 0M 0L 0I
Secrets 0🔑

jorgepiloto
jorgepiloto approved these changes Apr 11, 2024
View reviewed changes
doc-style/action.yml Outdated Show resolved Hide resolved
@jorgepiloto jorgepiloto removed the blocked Cannot address this till other issues are solved first label Apr 11, 2024
@jorgepiloto jorgepiloto marked this pull request as ready for review April 11, 2024 14:17
@jorgepiloto jorgepiloto requested a review from a team as a code owner April 11, 2024 14:17
@RobPasMue RobPasMue changed the title chore: Update default vale version 3.3.0 chore: Update default vale version 3.4.1 Apr 15, 2024
RobPasMue
RobPasMue reviewed Apr 16, 2024
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments

doc/source/migrations/docs-style-vale-version-update.rst Outdated Show resolved Hide resolved
doc/source/migrations/docs-style-vale-version-update.rst Outdated Show resolved Hide resolved
doc/source/migrations/docs-style-vale-version-update.rst Outdated Show resolved Hide resolved
doc/source/migrations/docs-style-vale-version-update.rst Outdated Show resolved Hide resolved
doc/source/migrations/docs-style-vale-version-update.rst Outdated Show resolved Hide resolved
doc/source/migrations/docs-style-vale-version-update.rst Outdated Show resolved Hide resolved
doc/source/migrations/index.rst Outdated Show resolved Hide resolved
doc/source/migrations/index.rst Outdated Show resolved Hide resolved
doc/source/migrations/index.rst Outdated Show resolved Hide resolved
doc/source/migrations/index.rst Outdated Show resolved Hide resolved
dipinknair and others added 2 commits April 16, 2024 07:40
@dipinknair @RobPasMue
Apply suggestions from code review
f7efa8a 
review changes

Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
@dipinknair
remove deprecation warning
e726cb6
@RobPasMue
Copy link
Member

All good @dipinknair - feel free to merge

@dipinknair dipinknair merged commit 88e9a14 into main Apr 16, 2024
16 checks passed
@dipinknair dipinknair deleted the maint/vale-update branch April 16, 2024 14:05
@jorgepiloto jorgepiloto mentioned this pull request Apr 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobPasMue RobPasMue RobPasMue approved these changes

@jorgepiloto jorgepiloto Awaiting requested review from jorgepiloto

Assignees
No one assigned
Labels
maintenance Package and maintenance related release Anything related to an incoming release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dipinknair @jorgepiloto @RobPasMue @Revathyvenugopal162