Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: add tests to actions #38

Merged
merged 1 commit into from
Nov 7, 2022
Merged

FEAT: add tests to actions #38

merged 1 commit into from
Nov 7, 2022
+148 −0

Conversation

jorgepiloto
Copy link
Member

@jorgepiloto jorgepiloto commented Nov 7, 2022 •
edited
Loading

The following reusable actions are already tested in the CI/CD of this repository:

  • The code style action
  • The doc style action
  • The doc build action
  • The doc deploy dev action
  • The doc deploy stable action
  • The release-github action

This pull-request allows to test the:

  • The release-private action
  • The release-public

:by using a demo package. The public release is done to the Test PyPI.

@github-actions github-actions bot added the enhancement General improvements to existing features label Nov 7, 2022
@jorgepiloto jorgepiloto force-pushed the feat/add-tests branch 7 times, most recently from 94a80fd to 92e30e3 Compare November 7, 2022 10:46
@github-actions github-actions bot added the maintenance Generic maintenance related label Nov 7, 2022
@jorgepiloto jorgepiloto force-pushed the feat/add-tests branch 9 times, most recently from 0c107e6 to a6f7b3e Compare November 7, 2022 13:49
@jorgepiloto
Copy link
Member Author

I see why this is failing. No matter the changes I apply to the actions, those are not going to change since they are pointing to main version.

I wish #37 had worked out but after checking third party actions, it looks like it is not possible to use GitHub substitution in the uses keyword.

@jorgepiloto
Copy link
Member Author

I will fix the changes discovered in here and merge. It is the only way we have to test this.

@jorgepiloto jorgepiloto force-pushed the feat/add-tests branch 7 times, most recently from dfcc8b3 to 9a7f86b Compare November 7, 2022 14:34
@jorgepiloto
Copy link
Member Author

This is finally working! 🎉

And it even found various bugs in the release pipeline. Great!

@jorgepiloto jorgepiloto marked this pull request as ready for review November 7, 2022 14:39
@jorgepiloto jorgepiloto requested a review from a team November 7, 2022 14:39
GuillemBarroso
GuillemBarroso approved these changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@GuillemBarroso GuillemBarroso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Well done.

@jorgepiloto jorgepiloto merged commit b5ec31e into main Nov 7, 2022
@jorgepiloto jorgepiloto deleted the feat/add-tests branch November 7, 2022 14:43
@jorgepiloto jorgepiloto mentioned this pull request Nov 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillemBarroso GuillemBarroso

Assignees
No one assigned
Labels
enhancement General improvements to existing features maintenance Generic maintenance related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jorgepiloto @GuillemBarroso