Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: add fundamental workflows #2

Merged
merged 1 commit into from
Oct 10, 2022
Merged

FEAT: add fundamental workflows #2

merged 1 commit into from
Oct 10, 2022
+96 −0

Conversation

jorgepiloto
Copy link
Member

@jorgepiloto jorgepiloto commented Oct 10, 2022 •
edited
Loading

This pull-request partially solves for #1 by implementing some style workflows:

  • Code style checking using pre-commit and tox
  • Documentation style checking using Vale

Sorry, something went wrong.

@jorgepiloto jorgepiloto force-pushed the feat/workflows branch 5 times, most recently from d51c074 to 8e3fa67 Compare October 10, 2022 13:18
@jorgepiloto jorgepiloto marked this pull request as ready for review October 10, 2022 13:39
@jorgepiloto jorgepiloto requested review from MaxJPRey and a team and removed request for MaxJPRey October 10, 2022 13:39
@jorgepiloto jorgepiloto merged commit 3abadfc into main Oct 10, 2022
@jorgepiloto jorgepiloto deleted the feat/workflows branch October 10, 2022 15:30
germa89
germa89 reviewed Oct 11, 2022
View reviewed changes
Copy link
Contributor

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@germa89 germa89

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jorgepiloto @germa89