Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: add build-library, release-private and release-public actions #14

Merged
merged 8 commits into from
Oct 24, 2022
Merged

FEAT: add build-library, release-private and release-public actions #14

merged 8 commits into from
Oct 24, 2022
+225 −1

Conversation

jorgepiloto
Copy link
Member

No description provided.

@github-actions github-actions bot added the enhancement General improvements to existing features label Oct 21, 2022
@jorgepiloto
FEAT: add release-private action

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
609358a
@jorgepiloto
FEAT: add release-public action

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
755ef20
@jorgepiloto
FEAT: add release-github action

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
17681d0
@jorgepiloto jorgepiloto force-pushed the feat/actions branch 2 times, most recently from 6ac0de3 to d20660b Compare October 21, 2022 09:46
@jorgepiloto jorgepiloto requested a review from a team October 21, 2022 09:46
@jorgepiloto
FIX: missing shell in run commands

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
d20660b
RobPasMue
RobPasMue approved these changes Oct 21, 2022
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments but LGTM overall :) This is going to be so useful to homogenize all repos... love it!

MaxJPRey
MaxJPRey reviewed Oct 22, 2022
View reviewed changes
MaxJPRey
MaxJPRey reviewed Oct 22, 2022
View reviewed changes
MaxJPRey
MaxJPRey approved these changes Oct 22, 2022
View reviewed changes
Copy link
Contributor

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great.

jorgepiloto and others added 2 commits October 24, 2022 08:05
@jorgepiloto @MaxJPRey
FEAT: add suggestions from code review
44a3cf3 
Co-authored-by: Maxime Rey <87315832+MaxJPRey@users.noreply.github.com>
@jorgepiloto
FEAT: add release-github action
2d2c3db
@jorgepiloto jorgepiloto force-pushed the feat/actions branch 2 times, most recently from 5f1dd44 to 8ba021f Compare October 24, 2022 06:31
@jorgepiloto jorgepiloto merged commit f326281 into main Oct 24, 2022
@jorgepiloto jorgepiloto deleted the feat/actions branch October 24, 2022 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobPasMue RobPasMue

@MaxJPRey MaxJPRey

Assignees
No one assigned
Labels
enhancement General improvements to existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jorgepiloto @RobPasMue @MaxJPRey