-
Notifications
You must be signed in to change notification settings - Fork 23.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support action_plugin
in plugin_routing_schema
#82562
Conversation
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
test/lib/ansible_test/_util/controller/sanity/code-smell/runtime-metadata.py
Outdated
Show resolved
Hide resolved
3604787
to
62a24bb
Compare
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
62a24bb
to
16aa5d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this!
now validation schema matches reality Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com> Co-authored-by: s-hertel <19572925+s-hertel@users.noreply.github.com>
now validation schema matches reality Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com> Co-authored-by: s-hertel <19572925+s-hertel@users.noreply.github.com>
now validation schema matches reality Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com> Co-authored-by: s-hertel <19572925+s-hertel@users.noreply.github.com> (cherry picked from commit b01f1f2)
now validation schema matches reality Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com> Co-authored-by: s-hertel <19572925+s-hertel@users.noreply.github.com> (cherry picked from commit b01f1f2)
now validation schema matches reality Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com> Co-authored-by: s-hertel <19572925+s-hertel@users.noreply.github.com> (cherry picked from commit b01f1f2)
now validation schema matches reality Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com> Co-authored-by: s-hertel <19572925+s-hertel@users.noreply.github.com> (cherry picked from commit b01f1f2)
now validation schema matches reality Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com> Co-authored-by: s-hertel <19572925+s-hertel@users.noreply.github.com> (cherry picked from commit b01f1f2)
…ema (#82562) (#82583) * Support `action_plugin` in plugin_routing_schema (#82562) now validation schema matches reality Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com> Co-authored-by: s-hertel <19572925+s-hertel@users.noreply.github.com> (cherry picked from commit b01f1f2) * Module redirects should be FQCR Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com> * pep8 fixes Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com> --------- Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@bcoca @NilashishC @s-hertel any chance this is responsible for the coverage drop @ https://github.com/ansible/ansible/blob/aa40167/test/support/windows-integration/collections/ansible_collections/ansible/windows/plugins/plugin_utils/_reboot.py#L550-L553? |
@bcoca it shouldn't be, because the drop happened in between the last few commits. That merge was like a week ago. |
I don't see how this would have increased/decreased the coverage for any of the files in https://app.codecov.io/gh/ansible/ansible/commit/b01f1f207c9c46eda8f8e8ffab8bd4b99e03c754/indirect-changes :/ |
Nevermind.. I figured out how to trigger it via the Azure Pipelines UI. |
OTOH, that was quick. So a full CI run didn't happen. |
@webknjaz To trigger a full CI run with coverage, add the comments |
@webknjaz The commit it's compared against shows an increase in coverage to that same file + section, but also seems unrelated https://app.codecov.io/gh/ansible/ansible/commit/6935c8e303440addd3871ecf8e04bde61080b032/indirect-changes#92e9c03abff1ec4c0a82181a533d5aa1-L547. In fact, looks like the coverage has been changing repeatedly for a while (https://app.codecov.io/gh/ansible/ansible/commit/4479c9df13aedec52f4971fb2a5a9c3c9fd92ba1/indirect-changes, https://app.codecov.io/gh/ansible/ansible/commit/8af920c8924b2fd9a0e4192c3c7e6085b687bfdc/indirect-changes). It seems like the coverage is just inconsistent. |
@s-hertel my understanding is that we only get coverage uploads for the nightly runs. So we wouldn't see coverage for the intermediate commits if there's more than one merge per day. |
That reflects my understanding too. I don't see how that's related to my comment. |
v2.16.3 ======= Release Summary --------------- | Release Date: 2024-01-29 | `Porting Guide <https://docs.ansible.com/ansible-core/2.16/porting_guides/porting_guide_core_2.16.html>`__ Security Fixes -------------- - ANSIBLE_NO_LOG - Address issue where ANSIBLE_NO_LOG was ignored (CVE-2024-0690) Bugfixes -------- - Run all handlers with the same ``listen`` topic, even when notified from another handler (ansible/ansible#82363). - ``ansible-galaxy role import`` - fix using the ``role_name`` in a standalone role's ``galaxy_info`` metadata by disabling automatic removal of the ``ansible-role-`` prefix. This matches the behavior of the Galaxy UI which also no longer implicitly removes the ``ansible-role-`` prefix. Use the ``--role-name`` option or add a ``role_name`` to the ``galaxy_info`` dictionary in the role's ``meta/main.yml`` to use an alternate role name. - ``ansible-test sanity --test runtime-metadata`` - add ``action_plugin`` as a valid field for modules in the schema (ansible/ansible#82562). - ansible-config init will now dedupe ini entries from plugins. - ansible-galaxy role import - exit with 1 when the import fails (ansible/ansible#82175). - ansible-galaxy role install - normalize tarfile paths and symlinks using ``ansible.utils.path.unfrackpath`` and consider them valid as long as the realpath is in the tarfile's role directory (ansible/ansible#81965). - delegate_to when set to an empty or undefined variable will now give a proper error. - dwim functions for lookups should be better at detectging role context even in abscense of tasks/main. - roles, code cleanup and performance optimization of dependencies, now cached, and ``public`` setting is now determined once, at role instantiation. - roles, the ``static`` property is now correctly set, this will fix issues with ``public`` and ``DEFAULT_PRIVATE_ROLE_VARS`` controls on exporting vars. - unsafe data - Enable directly using ``AnsibleUnsafeText`` with Python ``pathlib`` (ansible/ansible#82414)
SUMMARY
As per #77265 and devel loader code as well,
action_plugin
should be a valid entry inplugin_routing
schema.Related PR: ansible-collections/cisco.nxos#804
ISSUE TYPE