[2.15] fix installing roles with symlinks containing '..' (#82165) #82324
+231
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
bug
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ansibot
added
the
needs_revision
|
@s-hertel try rebasing? |
ansibot
added
the
stale_ci
…ble#82165) Set the tarfile attribute to a normalized value from unfrackpath instead of validating path parts and omiting potentially invald parts Allow tarfile paths/links containing '..', '$', '~' as long as the normalized realpath is in the tarfile's role directory (cherry picked from commit 3a42a00)
s-hertel
force-pushed
the
backport/2.15/82165
branch
from
57dc9bf
to
4734b29
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
ansibot
removed
ci_verified
|
Any update on this? Currently experiencing this bug on AWX 3.5.1. |
ansibot
added
the
stale_ci
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ansibot
removed
the
stale_ci
sivel
removed
the
needs_triage
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Backporting #82165
Set the tarfile attribute to a normalized value from unfrackpath instead of validating path parts and omiting potentially invald parts
Allow tarfile paths/links containing '..', '$', '~' as long as the normalized realpath is in the tarfile's role directory
(cherry picked from commit 3a42a00)
ISSUE TYPE