Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support action_plugin in plugin_routing_schema #82562

Merged
merged 4 commits into from Jan 19, 2024
Merged

Support action_plugin in plugin_routing_schema #82562

merged 4 commits into from Jan 19, 2024

Conversation

NilashishC
Copy link
Contributor

@NilashishC NilashishC commented Jan 18, 2024 •
edited

SUMMARY

As per #77265 and devel loader code as well, action_plugin should be a valid entry in plugin_routing schema.

Related PR: ansible-collections/cisco.nxos#804

ISSUE TYPE
  • Bugfix Pull Request (?)

@NilashishC
Support action_plugin key in plugin_routing_schema
4f90429 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@ansibot ansibot added bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. labels Jan 18, 2024
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Jan 18, 2024
@NilashishC NilashishC force-pushed the fix_schema_plugin_routing branch 2 times, most recently from 3604787 to 62a24bb Compare January 19, 2024 07:16
@NilashishC
action_plugin key should only be valid for modules
16aa5d7 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
s-hertel
s-hertel approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@s-hertel s-hertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@bcoca bcoca enabled auto-merge (squash) January 19, 2024 16:17
@bcoca bcoca merged commit b01f1f2 into ansible:devel Jan 19, 2024
62 checks passed
NilashishC added a commit to NilashishC/ansible that referenced this pull request Jan 22, 2024
@NilashishC @s-hertel
Support action_plugin in plugin_routing_schema (ansible#82562)
9f70fb3 
now validation schema matches reality

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
Co-authored-by: s-hertel <19572925+s-hertel@users.noreply.github.com>
NilashishC added a commit to NilashishC/ansible that referenced this pull request Jan 22, 2024
@NilashishC @s-hertel
Support action_plugin in plugin_routing_schema (ansible#82562)
01dd61a 
now validation schema matches reality

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
Co-authored-by: s-hertel <19572925+s-hertel@users.noreply.github.com>
NilashishC added a commit to NilashishC/ansible that referenced this pull request Jan 22, 2024
@NilashishC
Support action_plugin in plugin_routing_schema (ansible#82562)
ef74447 
now validation schema matches reality

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
Co-authored-by: s-hertel <19572925+s-hertel@users.noreply.github.com>
(cherry picked from commit b01f1f2)
NilashishC added a commit to NilashishC/ansible that referenced this pull request Jan 22, 2024
@NilashishC
Support action_plugin in plugin_routing_schema (ansible#82562)
b11151f 
now validation schema matches reality

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
Co-authored-by: s-hertel <19572925+s-hertel@users.noreply.github.com>
(cherry picked from commit b01f1f2)
NilashishC added a commit to NilashishC/ansible that referenced this pull request Jan 22, 2024
@NilashishC
Support action_plugin in plugin_routing_schema (ansible#82562)
75d9ba0 
now validation schema matches reality

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
Co-authored-by: s-hertel <19572925+s-hertel@users.noreply.github.com>
(cherry picked from commit b01f1f2)
sivel pushed a commit that referenced this pull request Jan 22, 2024
@NilashishC
Support action_plugin in plugin_routing_schema (#82562) (#82581)
d817f5e 
now validation schema matches reality

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
Co-authored-by: s-hertel <19572925+s-hertel@users.noreply.github.com>
(cherry picked from commit b01f1f2)
sivel pushed a commit that referenced this pull request Jan 22, 2024
@NilashishC
Support action_plugin in plugin_routing_schema (#82562) (#82582)
686fe80 
now validation schema matches reality

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
Co-authored-by: s-hertel <19572925+s-hertel@users.noreply.github.com>
(cherry picked from commit b01f1f2)
sivel pushed a commit that referenced this pull request Jan 22, 2024
@NilashishC
[backport][stable-2.14] Support action_plugin in plugin_routing_sch…
aa37f3c 
…ema (#82562) (#82583)

* Support `action_plugin` in plugin_routing_schema (#82562)

now validation schema matches reality

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
Co-authored-by: s-hertel <19572925+s-hertel@users.noreply.github.com>
(cherry picked from commit b01f1f2)

* Module redirects should be FQCR

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* pep8 fixes

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

---------

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@webknjaz
Copy link
Member

@bcoca @NilashishC @s-hertel any chance this is responsible for the coverage drop @ https://github.com/ansible/ansible/blob/aa40167/test/support/windows-integration/collections/ansible_collections/ansible/windows/plugins/plugin_utils/_reboot.py#L550-L553?

(https://app.codecov.io/gh/ansible/ansible/commit/b01f1f207c9c46eda8f8e8ffab8bd4b99e03c754/indirect-changes)

@bcoca
Copy link
Member

bcoca commented Jan 22, 2024

@webknjaz i would think #82526 is more likely culprit for that

@webknjaz
Copy link
Member

@bcoca it shouldn't be, because the drop happened in between the last few commits. That merge was like a week ago.

@s-hertel
Copy link
Contributor

s-hertel commented Jan 22, 2024 •
edited

I don't see how this would have increased/decreased the coverage for any of the files in https://app.codecov.io/gh/ansible/ansible/commit/b01f1f207c9c46eda8f8e8ffab8bd4b99e03c754/indirect-changes :/

@webknjaz
Copy link
Member

webknjaz commented Jan 22, 2024 •
edited

@bcoca @s-hertel this is puzzling because the only other commits in between the coverage change are #82569 and #82570... And they only delete dead code.

@webknjaz
Copy link
Member

@mattclay there's a small coverage drop that seems to be caused by this change, any idea on how to verify it? Is it hard to trigger a nightly-like CI run against the previous commit 853423c?

@webknjaz
Copy link
Member

Nevermind.. I figured out how to trigger it via the Azure Pipelines UI.

@webknjaz
Copy link
Member

OTOH, that was quick. So a full CI run didn't happen.

@mattclay
Copy link
Member

@webknjaz To trigger a full CI run with coverage, add the comments ci_complete and ci_coverage to the latest commit message on the PR.

@s-hertel
Copy link
Contributor

This commit b01f1f2 compared to 6935c8e

@webknjaz The commit it's compared against shows an increase in coverage to that same file + section, but also seems unrelated https://app.codecov.io/gh/ansible/ansible/commit/6935c8e303440addd3871ecf8e04bde61080b032/indirect-changes#92e9c03abff1ec4c0a82181a533d5aa1-L547. In fact, looks like the coverage has been changing repeatedly for a while (https://app.codecov.io/gh/ansible/ansible/commit/4479c9df13aedec52f4971fb2a5a9c3c9fd92ba1/indirect-changes, https://app.codecov.io/gh/ansible/ansible/commit/8af920c8924b2fd9a0e4192c3c7e6085b687bfdc/indirect-changes). It seems like the coverage is just inconsistent.

@webknjaz
Copy link
Member

@s-hertel my understanding is that we only get coverage uploads for the nightly runs. So we wouldn't see coverage for the intermediate commits if there's more than one merge per day.
That said, you might be onto something. I'll have to double check.

@s-hertel
Copy link
Contributor

That reflects my understanding too. I don't see how that's related to my comment.

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Jan 30, 2024
ansible-core: updated to 2.16.3
3c3a069 
v2.16.3
=======

Release Summary
---------------

| Release Date: 2024-01-29
| `Porting Guide <https://docs.ansible.com/ansible-core/2.16/porting_guides/porting_guide_core_2.16.html>`__


Security Fixes
--------------

- ANSIBLE_NO_LOG - Address issue where ANSIBLE_NO_LOG was ignored (CVE-2024-0690)

Bugfixes
--------

- Run all handlers with the same ``listen`` topic, even when notified from another handler (ansible/ansible#82363).
- ``ansible-galaxy role import`` - fix using the ``role_name`` in a standalone role's ``galaxy_info`` metadata by disabling automatic removal of the ``ansible-role-`` prefix. This matches the behavior of the Galaxy UI which also no longer implicitly removes the ``ansible-role-`` prefix. Use the ``--role-name`` option or add a ``role_name`` to the ``galaxy_info`` dictionary in the role's ``meta/main.yml`` to use an alternate role name.
- ``ansible-test sanity --test runtime-metadata`` - add ``action_plugin`` as a valid field for modules in the schema (ansible/ansible#82562).
- ansible-config init will now dedupe ini entries from plugins.
- ansible-galaxy role import - exit with 1 when the import fails (ansible/ansible#82175).
- ansible-galaxy role install - normalize tarfile paths and symlinks using ``ansible.utils.path.unfrackpath`` and consider them valid as long as the realpath is in the tarfile's role directory (ansible/ansible#81965).
- delegate_to when set to an empty or undefined variable will now give a proper error.
- dwim functions for lookups should be better at detectging role context even in abscense of tasks/main.
- roles, code cleanup and performance optimization of dependencies, now cached,  and ``public`` setting is now determined once, at role instantiation.
- roles, the ``static`` property is now correctly set, this will fix issues with ``public`` and ``DEFAULT_PRIVATE_ROLE_VARS`` controls on exporting vars.
- unsafe data - Enable directly using ``AnsibleUnsafeText`` with Python ``pathlib`` (ansible/ansible#82414)
@ansible ansible locked and limited conversation to collaborators Feb 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@s-hertel s-hertel s-hertel approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@NilashishC @webknjaz @bcoca @s-hertel @mattclay @ansibot @jborean93