-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support notes and requirements in role entrypoint argument specs #4017
Draft
felixfontein
wants to merge
2
commits into
ansible:main
Choose a base branch
from
felixfontein:roles-schema
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfontein
requested review from
Qalthos and
priyamsahoo
and removed request for
a team
February 10, 2024 13:11
audgirka
force-pushed
the
roles-schema
branch
from
February 12, 2024 07:58
1649d06
to
2129f62
Compare
ssbarnea
approved these changes
May 4, 2024
@felixfontein Can we move this out of draft? LGTM. |
@ssbarnea from my POV yes, since antsibull-docs supported these things for a long time already, but it's not clear which parts ansible-core wants to support or wants to explicitly not support (ansible/ansible#81796 (comment)). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ansible/ansible#81735 and ansible/ansible#81796.
seealso
andversion_added
is already supported, so there's nothing to do.