Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue #3932 fix eval of github.action_ref #3933

Closed
wants to merge 1 commit into from
Closed

issue #3932 fix eval of github.action_ref #3933

wants to merge 1 commit into from

Conversation

zerwes
Copy link

@zerwes zerwes commented Dec 6, 2023 •
edited by audgirka

fixes #3932

@zerwes zerwes requested a review from a team as a code owner December 6, 2023 13:12
@zerwes zerwes requested review from cristianonicolai and Qalthos and removed request for a team December 6, 2023 13:12
This was referenced Dec 6, 2023
Closed
Closed
@audgirka audgirka added the bug label Dec 6, 2023
@ssbarnea
Copy link
Member

ssbarnea commented Dec 6, 2023

I doubt that this is fixing anything because the quotes are just optional for this.

@zerwes
Copy link
Author

zerwes commented Dec 6, 2023

@ssbarnea ... you are right.
Seems that my testing was messed up due to my assumption that #3762 for #3928 fixed this in a backward compatible way ...

@zerwes zerwes closed this Dec 6, 2023
@zerwes zerwes deleted the issue-3932 branch December 6, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianonicolai cristianonicolai Awaiting requested review from cristianonicolai cristianonicolai is a code owner automatically assigned from ansible/devtools

@Qalthos Qalthos Awaiting requested review from Qalthos Qalthos is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
bug
Projects
🧰 devtools project board
Archived in project
Milestone
No milestone
3 participants
@zerwes @ssbarnea @audgirka