Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fup to : #3928 the current ansible-lint github workflow is using the latest checkout from main, indifferent of the version specified #3932

Closed
zerwes opened this issue Dec 6, 2023 · 6 comments
Labels

Comments

@zerwes
Copy link

zerwes commented Dec 6, 2023

Summary

see #3928 (comment)

even if I specify a tag/version in my github action, the ansible-lint workflow will run against main

Issue Type
  • Bug Report
OS / ENVIRONMENT

github workflow

STEPS TO REPRODUCE

ansible-lint workflow:

uses: ansible/ansible-lint@v6.22.0

will run against main

Run ansible/ansible-lint@v6.22.0
  with:
    setup_python: true
Run wget --output-document=.git/ansible-lint-requirements.txt https://raw.githubusercontent.com/ansible/ansible-lint/main/.config/requirements-lock.txt
...
Building wheels for collected packages: ansible-lint
175
  Building wheel for ansible-lint (pyproject.toml): started
176
  Building wheel for ansible-lint (pyproject.toml): finished with status 'done'
177
  Created wheel for ansible-lint: filename=ansible_lint-6.22.2.dev8-py3-none-any.whl size=297703 
...
ansible-lint 6.22.2.dev8 using ansible-core:2.16.0 ansible-compat:4.1.10 ruamel-yaml:0.18.5 ruamel-yaml-clib:0.2.8
You are using a pre-release version of ansible-lint.
Run ansible-lint
...
@zerwes zerwes added bug new Triage required labels Dec 6, 2023
@zerwes
Copy link
Author

zerwes commented Dec 6, 2023

it seems the evaluation of the VAR github.action_ref in #3762 has changed

@zerwes
Copy link
Author

zerwes commented Dec 6, 2023

while debuging in my fork:
the var github.action_ref seems empty

@zerwes
Copy link
Author

zerwes commented Dec 6, 2023

https://docs.github.com/en/actions/learn-github-actions/contexts#context-availability

github.action_ref
string
For a step executing an action, this is the ref of the action being executed. For example, v2.
Do not use in the run context. To make this context work with composite actions, reference it within the env context of the composite action.

zerwes added a commit to zerwes/ansible-lint that referenced this issue Dec 6, 2023
zerwes added a commit to zerwes/ansible-lint that referenced this issue Dec 6, 2023
@ssbarnea ssbarnea removed the new Triage required label Dec 6, 2023
@zerwes
Copy link
Author

zerwes commented Dec 6, 2023

#3928 (comment)
would be great if a fix for versions before 6.22.1 would be applied

@zerwes
Copy link
Author

zerwes commented Feb 1, 2024

We migrated all our to 6.22.2 as no backward fix was in view.
So for my part this is not relevant anymore.

@zerwes zerwes closed this as not planned Won't fix, can't repro, duplicate, stale Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants