Make compatible with requests 2.29.0 and urllib3 2.0 #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfontein
force-pushed
the
requests
branch
2 times, most recently
from
01e9159
to
3c1fb8f
Compare
|
I've also created a similar PR for Docker SDK for Python (docker/docker-py#3116). |
felixfontein
changed the title
felixfontein
changed the title
|
According to docker/docker-py#3113 (comment) this should also make the code compatible with urllib3 2.0. |
|
https://github.com/ansible-collections/community.docker/actions/runs/4874702225/jobs/8695973844?pr=614 shows that this is not done yet with urllib3 2.0. Unfortunately requests 2.30.0 has been yanked, so I cannot test this in CI anymore until they make a new release. |
|
Hmm, I didn't notice that the task that fails isn't our code, but pip. So this isn't a problem with this collection's code. I still think df8a492 is a good idea though. |
… new release with a fix.
…on has a new release with a fix." This reverts commit 698d544.
felixfontein
force-pushed
the
requests
branch
6 times, most recently
from
7d6ff0b
to
9a6c03a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Try to fix at least parts of #611.
Since requests 2.29.0, requests uses urllib3's native chunking ability (see psf/requests#6226). By using urllib3's
HTTPConnectionclass (which extends httplib.HTTPConnection`) we make sure that our HTTP transports support this as well.ISSUE TYPE
COMPONENT NAME
vendored Docker SDK for Python