Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix module type detection #334

Merged
merged 4 commits into from
Oct 31, 2021
Merged

fix module type detection #334

merged 4 commits into from
Oct 31, 2021

Conversation

nosovk
Copy link
Contributor

@nosovk nosovk commented Oct 31, 2021

#332
removing that line will allow autodetect to work correctly.
todo: more build targets available, see: https://github.com/pngwn/MDsveX/blob/master/packages/mdsvex/rollup.config.js

nosovk and others added 2 commits October 31, 2021 11:16
angus-c#332
removing that line will allow autodetect to work correctly.
todo: more build targets available, see: https://github.com/pngwn/MDsveX/blob/master/packages/mdsvex/rollup.config.js
@angus-c
Copy link
Owner

angus-c commented Oct 31, 2021

@raulfdm what do you think?

@nosovk
Copy link
Contributor Author

nosovk commented Oct 31, 2021

looks like that PR also needed 🤷

@angus-c
Copy link
Owner

angus-c commented Oct 31, 2021

Ok I merged, thank you.
However I'm AFK right now and can't verify that commonjs usage still works as before with this change. I will publish once I have run this check

@angus-c angus-c merged commit 4e1f74f into angus-c:master Oct 31, 2021
@rqbazan
Copy link
Contributor

rqbazan commented Nov 1, 2021

@angus-c
Copy link
Owner

angus-c commented Nov 1, 2021

Ok all versioned and published. Let me know if you have any more issues @nosovk @rqbazan

@angus-c angus-c mentioned this pull request Nov 1, 2021
@nosovk
Copy link
Contributor Author

nosovk commented Nov 1, 2021

Unfortunately it didn't help
image
MailCheck-co/mailcheck.site#608 PR to update svelte kit to the latest version. Will check it a bit later, currently it fails with the same error :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants