NextJS incompatibility

[rqbazan]

Hey @angus-c 👋

Seems like the latest version of all the packages has introduced an incompatibility with NextJS apps.

Reproduce

1. Clone https://github.com/rqbazan/just-and-nextjs-esm-issue
2. Install all dependencies with yarn
3. Run the build process: yarn build ❌
4. Profit!

./node_modules/just-map-values/index.esm.js
Module parse failed: 'import' and 'export' may appear only with 'sourceType: module' (22:0)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
| }
|
> export { objectMapValues as default };
|

Possible solution

• Change "commonjs" to "module" in package.json

After the change to "type": "module" you can run yarn build ✅:

rm -rf .next && yarn build

[nosovk]

yep, svelte-kit builds also broke on latest update (and they are "module" from start)

broken build one:
https://github.com/NodeArt/nodeartio/pull/454

accidentally merged broken version
MailCheck-co/mailcheck.site#601
and reverting it restored build
MailCheck-co/mailcheck.site@c8af869

it seems that ESM build isn't correct for now (or it's declaration in package.json)

[nosovk]

#328
that one also should be merged (I was wrong, real problem fixed in that PR) by @PuruVJ

[angus-c]

#328 merged.
Considering other issue now (cc @raulfdm)

[angus-c]

Should be fixed now #334

[raulfdm]

@angus-c Sorry my absence, I had to stay offline yesterday the whole day...

Curious to understand why nextjs was picking up ESM if the main type was specified to to commonjs.

Anyhow, I'm glad it's fixed. I should've tested in all biggest frameworks (nuxt, next, vite, angular, node, etc) to ensure it's all working perfectly everything. My bad

[angus-c]

yep, svelte-kit builds also broke on latest update (and they are "module" from start)

Hi @nosovk can you check with latest major build? It now uses .mjs suffix for esm module which should be more universally recognized

[PuruVJ]

@angus-c I checked just-shuffle, and it is working in sveltekit, so assumption is that all of em are working. Even I had the same problem with submodules, and renaming ESM outputs to .mjs helped, so all of just packages should also work

[angus-c]

Cool, thanks for confirming @PuruVJ. @nosovk said it also now works for him.