Skip to content

Create windows batch file for staging releases #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2016
Merged

Create windows batch file for staging releases #734

merged 1 commit into from
Jun 21, 2016

Conversation

NCC1701M
Copy link

Windows user can build material and create a release version.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Jun 21, 2016
@NCC1701M
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Jun 21, 2016
@jelbourn
Copy link
Member

@NCC1701M why do you need this?

@NCC1701M
Copy link
Author

For example as a workaround as long as custom themes are not implemented for everyone who want to try material2 but don't want to use the default theme. And for all who want to compile material2 on a windows machine

@jelbourn
Copy link
Member

LGTM

Perhaps we could delete this once bash support in Windows 10 makes it to the public release.

@jelbourn jelbourn merged commit 7a1bb19 into angular:master Jun 21, 2016
@devversion
Copy link
Member

@NCC1701M @jelbourn I'm just a bit wondering.

Normally in other projects (like Material 1 etc.) there will be no BAT scripts.

The default developer environment on Windows includes a Bash Terminal, like the Git Bash (MingW) or Cygwin.

Once we add BAT files to projects, we will have to add BAT files for other scripts as well. (Even) if the script is actually doing the same as the Bash Script (just different syntax).

Just throwing some thoughts here.

@jelbourn
Copy link
Member

@devversion I just don't really care that much about having the extra file. I'm not going to take extra steps to maintain it, though.

@NCC1701M
Copy link
Author

@devversion @jelbourn As I mentioned above it's a workaround as long as theming isn't working. As far as I'm concerned the file can be deleted after implementing theming.

@jelbourn That's ok if there is any problem with the file just contact me. I'll take care.

@devversion I am a windows developer and I've never needed a Bash Terminal ;-)

@devversion
Copy link
Member

devversion commented Jun 23, 2016

I'm fine with it. I just wanted to get the initial thoughts here.

It would be probably better to just make it a node file. This would work on all environments. But since it's a temporary workaround it's fine like that

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants