-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Create windows batch file for staging releases #734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
1 similar comment
CLAs look good, thanks! |
@NCC1701M why do you need this? |
For example as a workaround as long as custom themes are not implemented for everyone who want to try material2 but don't want to use the default theme. And for all who want to compile material2 on a windows machine |
LGTM Perhaps we could delete this once bash support in Windows 10 makes it to the public release. |
@NCC1701M @jelbourn I'm just a bit wondering. Normally in other projects (like Material 1 etc.) there will be no BAT scripts. The default developer environment on Windows includes a Bash Terminal, like the Git Bash (MingW) or Cygwin. Once we add BAT files to projects, we will have to add BAT files for other scripts as well. (Even) if the script is actually doing the same as the Bash Script (just different syntax). Just throwing some thoughts here. |
@devversion I just don't really care that much about having the extra file. I'm not going to take extra steps to maintain it, though. |
@devversion @jelbourn As I mentioned above it's a workaround as long as theming isn't working. As far as I'm concerned the file can be deleted after implementing theming. @jelbourn That's ok if there is any problem with the file just contact me. I'll take care. @devversion I am a windows developer and I've never needed a Bash Terminal ;-) |
I'm fine with it. I just wanted to get the initial thoughts here. It would be probably better to just make it a node file. This would work on all environments. But since it's a temporary workaround it's fine like that |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Windows user can build material and create a release version.