checkbox fix for #575 #582
Conversation
googlebot
added
the
cla: yes
|
@sendilkumarn Can you title your PRs such that it's clear what they're doing, and include some description that has a high level summary of your changes and why they fix the issue? Seeing just "checkbox fix" makes it more difficult to review. |
| @@ -11,7 +11,8 @@ | |||
| [attr.aria-labelledby]="ariaLabelledby" | |||
| (focus)="onInputFocus()" | |||
| (blur)="onInputBlur()" | |||
| (change)="onInteractionEvent($event)"> | |||
| (change)="onInteractionEvent($event)" | |||
| (click)="onInteractionEvent($event)"> | |||
There was a problem hiding this comment.
This doesn't seem right. What is the underlying bug you're trying to address?
There was a problem hiding this comment.
upon clicking, checkbox fires click function twice. Ideally it should fire it once right?
|
This change will also need a unit test. |
|
For PR - I will :) Unit Test, I totally forgot. I will add it by today. |
|
I will close this PR and add another. sorry for any inconvienience |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
#575