test(grid-list): add unit tests for grid-list #555
Conversation
googlebot
added
the
cla: yes
|
|
||
| it('should throw error if cols is not defined', () => { | ||
| var template = `<md-grid-list></md-grid-list>`; | ||
| return builder.overrideTemplate(TestGridList, template) |
There was a problem hiding this comment.
Rather than doing return on each build, you can simply make each test async and they should auto finish because zones.
| fixture.detectChanges(); | ||
| let tile = fixture.debugElement.query(By.directive(MdGridTile)); | ||
|
|
||
| // 149.5 * 2 = 299px + 1px gutter = 300px |
| {text: 'One', cols: 3, rows: 1, color: 'lightblue'}, | ||
| {text: 'Two', cols: 1, rows: 2, color: 'lightgreen'}, | ||
| {text: 'Three', cols: 1, rows: 1, color: 'lightpink'}, | ||
| {text: 'Four', cols: 2, rows: 1, color: '#DDBDF1'}, |
There was a problem hiding this comment.
Also these colors are boring. You should try some better ones like sienna, mediumaquamarine, or lemonchiffon.
There was a problem hiding this comment.
Ha, it's a relic from the demo page. I'll remove!
There was a problem hiding this comment.
|
LGTM |
kara
force-pushed
the
gridtest
branch
5 times, most recently
from
0748ef8 to
258513c
Compare
|
All tests are now passing (added a tick() to the 4 failures to fix Mobile Safari). Merging it in! |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
r: @jelbourn