Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(input): add ability to hide text divider #400

Closed
wants to merge 1 commit into from

Conversation

soyzamudio
Copy link

@hansl @kara @jelbourn

Adds the ability to show or hide the underline beneath the input (just like with the floating placeholder)

screen shot 2016-05-06 at 10 40 37 pm

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label May 7, 2016
@soyzamudio
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels May 7, 2016
@peterblazejewicz
Copy link
Contributor

That's called text divider, not underline.
Should it be allowed to hide per docs (just wondering)?
https://www.google.com/design/spec/components/text-fields.html#text-fields-input

@soyzamudio soyzamudio force-pushed the no-underline-input branch from 3cb5e84 to b779f74 Compare May 8, 2016 01:14

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@soyzamudio soyzamudio force-pushed the no-underline-input branch from b779f74 to 631e3bb Compare May 8, 2016 01:15
@soyzamudio soyzamudio changed the title feat(input): add ability to hide underline feat(input): add ability to hide text divider May 8, 2016
@jelbourn
Copy link
Member

jelbourn commented May 10, 2016

@soyzamudio I chatted with @hansl about this and we agreed that this is something that would be better done with CSS than a new directive API. We want people to be able to do something like

.md-input-underline {
  display: none;
}

To hide this part of the component. Right now the view encapsulation makes this difficult, so we're going to change the component to ViewEncapsulation.None and document the approach once we have our more complete documentation.

@jelbourn jelbourn closed this May 10, 2016
andrewseguin pushed a commit to andrewseguin/components that referenced this pull request Oct 15, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants