-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(input): add ability to hide text divider #400
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
1 similar comment
CLAs look good, thanks! |
That's called text divider, not underline. |
3cb5e84
to
b779f74
Compare
b779f74
to
631e3bb
Compare
@soyzamudio I chatted with @hansl about this and we agreed that this is something that would be better done with CSS than a new directive API. We want people to be able to do something like .md-input-underline {
display: none;
} To hide this part of the component. Right now the view encapsulation makes this difficult, so we're going to change the component to |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
@hansl @kara @jelbourn
Adds the ability to show or hide the underline beneath the input (just like with the floating placeholder)