fix(multiple): avoid repeating selectors in m3 themes #30645
Merged
+322
−291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewseguin
requested review from
crisbeto and
mmalerba
and removed request for
a team
andrewseguin
force-pushed
the
batch-override
branch
from
c602543 to
e06b260
Compare
crisbeto
approved these changes
Mar 19, 2025
| @@ -123,15 +123,15 @@ | |||
| @include _theme-from-tokens(inspection.get-theme-tokens($theme, typography)); | |||
| } @else { | |||
| @include sass-utils.current-selector-or-root() { | |||
| @include token-utils.create-token-values( | |||
| @include token-utils.create-token-values-mixed( | |||
There was a problem hiding this comment.
Should we come up some more explicit name for this function? We can do it in a separate PR.
There was a problem hiding this comment.
Yeah, we can bikeshed another name. The opposite case, -inline, would be an easy name but I dont know what not-inline would be
andrewseguin
added
action: merge
mistrykaran91
pushed a commit
to mistrykaran91/components
that referenced
this pull request
Mar 20, 2025
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #29596 we switched to outputting each group of tokens under a different selector in order to work around an Sass deprecation warning. Now that M3 themes are purely token-based, we can switch back to the old approach which produces smaller themes and makes the tokens easier to read in the dev tools.
We have to keep the workaround in place for M2 themes, because they mixed CSS variables with other rules.