fix(multiple): stop exposing internal ripple implementation #29622
+6
−186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
requested review from
amysorto and
mmalerba
and removed request for
a team
crisbeto
commented
Aug 22, 2024
| @@ -109,12 +109,6 @@ export class MatRippleLoader implements OnDestroy { | |||
| } | |||
| } | |||
|
|
|||
| /** Returns the ripple instance for the given host element. */ | |||
| getRipple(host: HTMLElement): MatRipple | undefined { | |||
There was a problem hiding this comment.
Note: there's some more cleanup to be done in this file in order to stop instantiating MatRipple manually. I'll do it in a follow-up, because it'll conflict with #29620.
andrewseguin
approved these changes
Aug 22, 2024
crisbeto
force-pushed
the
remove-ripple-api
branch
from
744e726 to
c8657cb
Compare
Removes the code that exposes the ripple implementations of some components since they are internal details and they require some hacky workarounds to keep exposed. BREAKING CHANGE: * `MatButton.ripple` is no longer available. * `MatCheckbox.ripple` is no longer available. * `MatChip.ripple` is no longer available.
crisbeto
force-pushed
the
remove-ripple-api
branch
from
c8657cb to
decb3a7
Compare
angular-robot
bot
added
the
detected: breaking change
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Aug 23, 2024
Previously we had to manually instantiate `MatRipple` in order to maintain backwards compatibility, but it was problematic because it would break whenever we tried to use DI in `MatRipple` and it prevented us from switching to the `inject` function. Instantiating `MatRipple` is no longer necessary after angular#29622 so these changes switch to creating an internal `RippleRenderer` instead.
crisbeto
added a commit
that referenced
this pull request
Aug 23, 2024
…29630) Previously we had to manually instantiate `MatRipple` in order to maintain backwards compatibility, but it was problematic because it would break whenever we tried to use DI in `MatRipple` and it prevented us from switching to the `inject` function. Instantiating `MatRipple` is no longer necessary after #29622 so these changes switch to creating an internal `RippleRenderer` instead.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the code that exposes the ripple implementations of some components since they are internal details and they require some hacky workarounds to keep exposed.
BREAKING CHANGES:
MatButton.rippleis no longer available.MatCheckbox.rippleis no longer available.MatChip.rippleis no longer available.