fix(cdk/overlay): skip trigger interactions in outside click event #29044
+26
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const origin = this._getOriginElement(); | ||
| const target = _getEventTarget(event) as Element | null; | ||
|
|
||
| if (!target || !origin || (origin !== target && !origin.contains(target))) { |
There was a problem hiding this comment.
nit: the null checks appear to be redundant since contains returns false if target is null. This could be reduced to origin !== target && !origin?.contains(target))
There was a problem hiding this comment.
I'll get rid of the target check, but I'll leave in the one for origin since I don't want to end up comparing nulls.
andrewseguin
approved these changes
May 14, 2024
Adds some logic to skip the trigger when considering clicks outside of the overlay since filtering them is the most common case (e.g. we do it in some of our components) and can be annoying to deal with. Fixes angular#28949.
crisbeto
force-pushed
the
28949/overlay-outside-click
branch
from
68d7028 to
b868d9e
Compare
This was referenced Jun 12, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some logic to skip the trigger when considering clicks outside of the overlay since filtering them is the most common case (e.g. we do it in some of our components) and can be annoying to deal with.
Fixes #28949.