fix(material/core): prevent ng update schematic from checking node_modules #28152
+16
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
crisbeto
changed the title
…dules Fixes that the `ng update` schematic was cheking `node_modules` and .d.ts files when looking for legacy imports. Also changes the logic to only look at top-level imports and exports, as well as any files that don't include `@angular/material` at all. Fixes angular#28150.
crisbeto
force-pushed
the
28150/schematic-node-modules
branch
from
7216fce to
c1ce3eb
Compare
devversion
approved these changes
Nov 20, 2023
crisbeto
added a commit
that referenced
this pull request
Nov 20, 2023
…dules (#28152) Fixes that the `ng update` schematic was cheking `node_modules` and .d.ts files when looking for legacy imports. Also changes the logic to only look at top-level imports and exports, as well as any files that don't include `@angular/material` at all. Fixes #28150. (cherry picked from commit da692b1)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that the
ng updateschematic was chekingnode_modulesand .d.ts files when looking for legacy imports. Also changes the logic to only look at top-level imports and exports, as well as any files that don't include@angular/materialat all.Fixes #28150.