style(_button-base.scss): $md-icon-button-border-radius value change #223
Conversation
icon change from check circle to check to fix rtl display
Syncing with upstream
Conflicts: src/demo-app/button/button-demo.html
$md-icon-button-border-radius value change from 50px to reuse $md-fab-border-radius value of 50%
googlebot
added
the
cla: yes
| @@ -26,6 +21,12 @@ $md-fab-padding: 16px !default; | |||
| $md-mini-fab-size: 40px !default; | |||
| $md-mini-fab-padding: 8px !default; | |||
|
|
|||
| // Icon Button standards | |||
| $md-icon-button-size: 40px !default; | |||
| $md-icon-button-border-radius: $md-fab-border-radius; | |||
There was a problem hiding this comment.
Good catch. Could you just say 50%, though, rather than re-using the fab variable? Icon buttons aren't round because FABs are round, they just happen to also be round.
|
@RichOren could you squash your commits into one with the message |
$md-icon-button-border-radius value change from 50px to reuse $md-fab-border-radius value of 50%
|
Trying to squash my commits into one message but I have never done that and I am looking into it. Sorry. |
|
@RichOren You can use |
| @@ -13,11 +13,6 @@ $md-button-margin: 0 !default; | |||
| $md-button-line-height: 36px !default; | |||
| $md-button-border-radius: 3px !default; | |||
|
|
|||
| // Icon Button standards | |||
| $md-icon-button-size: 40px !default; | |||
| $md-icon-button-border-radius: 50px !default; | |||
There was a problem hiding this comment.
Great catch, seems like I unintentionally used px instead of percentage.
|
Sorry my repository is completely messed up I am going to delete it and start over. If you want to Delete this pull request it is fine. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
$md-icon-button-border-radius value change from 50px to reuse $md-fab-border-radius value of 50%