Skip to content

feat(md-card): add md-card-footer #1178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 23, 2016
Merged

feat(md-card): add md-card-footer #1178

merged 2 commits into from
Sep 23, 2016

Conversation

Nightapes
Copy link
Contributor

Bug, feature request, or proposal:

Bug

What is the expected behavior?

md-card-footer directive is missing.

@Directive({ selector: 'md-card-footer' }) export class MdCardFooter { }

What is the current behavior?

zone.js?1473057816570:484 Unhandled Promise rejection: Template parse errors: 'md-card-footer' is not a known element:

When using footer, the directive is not found

What are the steps to reproduce?

Add md-card-footer to the demo-app

What is the use-case or motivation for changing an existing behavior?

For adding a progress-bar add the bottom:
https://material.google.com/components/progress-activity.html#progress-activity-behavior

Which versions of Angular, Material, OS, browsers are affected?

Angular 2.0.0 RC.6 and Material2 alpha.8

Is there anything else we should know?

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Sep 5, 2016
@Nightapes
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Sep 5, 2016
@@ -76,7 +76,10 @@ md-card-actions {

md-card-footer {
position: absolute;
width: 100%;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kara could you review this change?

@hansl
Copy link
Contributor

hansl commented Sep 7, 2016

The rest looks good, just want to make sure the style changes are good.

Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara added action: merge The PR is ready for merge by the caretaker pr: lgtm and removed pr: needs review labels Sep 22, 2016
@kara kara merged commit 1c2a3f1 into angular:master Sep 23, 2016
@kara kara changed the title fix(md-card): add md-card-footer feat(md-card): add md-card-footer Sep 23, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants