-
Notifications
You must be signed in to change notification settings - Fork 6.8k
feat(md-card): add md-card-footer #1178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
1 similar comment
CLAs look good, thanks! |
@@ -76,7 +76,10 @@ md-card-actions { | |||
|
|||
md-card-footer { | |||
position: absolute; | |||
width: 100%; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kara could you review this change?
The rest looks good, just want to make sure the style changes are good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Bug, feature request, or proposal:
Bug
What is the expected behavior?
md-card-footer directive is missing.
@Directive({ selector: 'md-card-footer' }) export class MdCardFooter { }
What is the current behavior?
zone.js?1473057816570:484 Unhandled Promise rejection: Template parse errors: 'md-card-footer' is not a known element:
When using footer, the directive is not found
What are the steps to reproduce?
Add
md-card-footer
to the demo-appWhat is the use-case or motivation for changing an existing behavior?
For adding a progress-bar add the bottom:
https://material.google.com/components/progress-activity.html#progress-activity-behavior
Which versions of Angular, Material, OS, browsers are affected?
Angular 2.0.0 RC.6 and Material2 alpha.8
Is there anything else we should know?