-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(tabs): remove invalid property in documentation #1140
Conversation
* The `focusIndex` has been removed, and was actually the same as the `selectedIndex` from the description as well. * Also added a quick example for the `selectedIndex`
LGTM |
In fact, setting selectedIndex does no get you the same result as the focus. Does this issue mean that the selectedIndex will now have the same behaviour as the focus, or conversely we won't be able to set the focus on the desired tab? |
@marc-ferrer Sure it does not. But as said in my PR description, the documentation had the same description for the Also I guess, the If we make this public as an This functionality may come back in the future, but right now it does not make any sense (also since only tabs, which are selected are currently focusable) |
@devversion So I guess that it is not possible to manually set focus on a tab currently. And selectedIndex behaviour is not expected to change to include the focus efect.
Then how are we suposed to manage the tabs without mouse? When you use the tab key to select a tab from a list the focus moves accross the tabs and then you select the tab you want to move into. Don't get me wrong, I get that focusIndex got published as a public property when it shouldn't have been this way, and does not seem easy to implement an actual focusIndex. I just got a bit confused with that sentence of yours since what does not make any sense for me, is that only selected tabs are focusable. |
@marc-ferrer I'm sorry, my sentence was probably wrong. I'm only talking about the things I can see right now - I'm not the author of this component. At the moment you are able to move the focus between the different A few minutes ago, I made the But from my findings it seems like this property was Right now, this PR just makes sure that the documentation matches the current state of implementation. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
focusIndex
has been removed, and was actually the same as theselectedIndex
from the description as well.selectedIndex
Fixes #1134