Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docs step 6 property binding #60630

Closed
wants to merge 1 commit into from

Conversation

EriksonBahr
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Sorry, something went wrong.

Copy link

google-cla bot commented Mar 30, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@pullapprove pullapprove bot requested a review from kirjs March 30, 2025 19:47
@thePunderWoman thePunderWoman added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release area: docs Related to the documentation merge: fix commit message labels Mar 31, 2025
@ngbot ngbot bot added this to the Backlog milestone Mar 31, 2025
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 31, 2025
@thePunderWoman thePunderWoman removed the request for review from kirjs March 31, 2025 17:02
thePunderWoman pushed a commit that referenced this pull request Mar 31, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
PR Close #60630
@thePunderWoman
Copy link
Contributor

This PR was merged into the repository by commit a7d1293.

The changes were merged into the following branches: main, 19.2.x

@csvn
Copy link
Contributor

csvn commented Apr 3, 2025

Is this PR really correct? If I try to add <div [contentEditable]="{{isEditable}}"></div> in the tutorial editor, I get an error:

image

I think interpolation and binding are mutually exclusive? Either use [] to bind an expression to a property, or use {{}} to have dynamic parts in a string.

<div contentEditable="{{isEditable}}"></div>
<div [contentEditable]="isEditable"></div>

@JeanMeche
Copy link
Member

Yes, a fix already is already pending #60725.

@csvn
Copy link
Contributor

csvn commented Apr 3, 2025

@JeanMeche ahh, sorry, didn't see that PR. Thanks for mentioning it 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants