Resolve host binding type issues #60481
Closed
+115
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
action: review
angular-robot
bot
added
area: build & ci
crisbeto
commented
Mar 20, 2025
| @@ -279,7 +274,8 @@ export interface ImagePlaceholderConfig { | |||
| '[style.background-position]': 'placeholder ? "50% 50%" : null', | |||
| '[style.background-repeat]': 'placeholder ? "no-repeat" : null', | |||
| '[style.background-image]': 'placeholder ? generatePlaceholder(placeholder) : null', | |||
| '[style.filter]': `placeholder && shouldBlurPlaceholder(placeholderConfig) ? "blur(${PLACEHOLDER_BLUR_AMOUNT}px)" : null`, | |||
| '[style.filter]': | |||
| 'placeholder && shouldBlurPlaceholder(placeholderConfig) ? "blur(15px)" : null', | |||
There was a problem hiding this comment.
I removed the string interpolation here, because it was preventing type checking. It also seemed like it was there purely for the unit tests.
crisbeto
commented
Mar 20, 2025
| @@ -687,7 +683,7 @@ export class NgOptimizedImage implements OnInit, OnChanges { | |||
| * * A base64 encoded image, which is wrapped and passed through. | |||
| * * A boolean. If true, calls the image loader to generate a small placeholder url. | |||
| */ | |||
| private generatePlaceholder(placeholderInput: string | boolean): string | boolean | null { | |||
| protected generatePlaceholder(placeholderInput: string | boolean): string | boolean | null { | |||
There was a problem hiding this comment.
These had to be made protected, because it's not allowed to use private methods in templates/host bindings.
crisbeto
commented
Mar 20, 2025
| @@ -46,7 +46,7 @@ const CHECKBOX_VALUE_ACCESSOR: Provider = { | |||
| @Directive({ | |||
| selector: | |||
| 'input[type=checkbox][formControlName],input[type=checkbox][formControl],input[type=checkbox][ngModel]', | |||
| host: {'(change)': 'onChange($event.target.checked)', '(blur)': 'onTouched()'}, | |||
| host: {'(change)': 'onChange($any($event.target).checked)', '(blur)': 'onTouched()'}, | |||
There was a problem hiding this comment.
These are cast to any, because $event.target is an EventTarget and we have no way of casting it to HTMLInputElement. The other option we be to have a type assertion in a separate method, but I didn't want to add more runtime code here.
crisbeto
force-pushed
the
host-binding-errors
branch
2 times, most recently
from
e305e2e to
6d83cbf
Compare
angular-robot
bot
added
the
area: docs-infra
crisbeto
force-pushed
the
host-binding-errors
branch
5 times, most recently
from
c27cef3 to
25d60e4
Compare
Enables strict templates and type checking of host bindings against our own code.
Fixes type checking issues in the dev tools that weren't showing up, because we had `strictTemplates` turned off.
Fixes type issues in the host bindings of `NgOptimizedImage`.
Fixes some type issues that are being flagged now that we have type checking of host bindings.
Resolves typing issues inside host binding in adev.
Fixes some type checking issues in our own testing code that weren't showing up, because `strictTemplates` was turned off.
crisbeto
force-pushed
the
host-binding-errors
branch
from
25d60e4 to
4d6d1cc
Compare
thePunderWoman
approved these changes
Mar 20, 2025
devversion
approved these changes
Mar 20, 2025
devversion
approved these changes
Mar 20, 2025
JeanMeche
approved these changes
Mar 20, 2025
crisbeto
added
action: merge
|
This PR was merged into the repository by commit 911ad40. The changes were merged into the following branches: main |
alxhub
pushed a commit
that referenced
this pull request
Mar 20, 2025
Fixes type checking issues in the dev tools that weren't showing up, because we had `strictTemplates` turned off. PR Close #60481
alxhub
pushed a commit
that referenced
this pull request
Mar 20, 2025
Fixes type issues in the host bindings of `NgOptimizedImage`. PR Close #60481
alxhub
pushed a commit
that referenced
this pull request
Mar 20, 2025
Fixes some type issues that are being flagged now that we have type checking of host bindings. PR Close #60481
alxhub
pushed a commit
that referenced
this pull request
Mar 20, 2025
Resolves typing issues inside host binding in adev. PR Close #60481
alxhub
pushed a commit
that referenced
this pull request
Mar 20, 2025
Fixes some type checking issues in our own testing code that weren't showing up, because `strictTemplates` was turned off. PR Close #60481
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates our build setup to type check host bindings in our own directives, and fixes any pre-existing issues. This is a prerequisite for enabling the new type checking internally.