fix(core): capture stack for HMR errors #60067
Closed
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we send the `message` of an error thrown during HMR. That's usually not enough so now we also capture the stack trace. Relates to angular/angular-cli#29695.
crisbeto
added
action: review
clydin
approved these changes
Feb 23, 2025
crisbeto
added
action: merge
|
This PR was merged into the repository by commit e601bdc. The changes were merged into the following branches: main, 19.1.x, 19.2.x |
kirjs
pushed a commit
that referenced
this pull request
Feb 24, 2025
Currently we send the `message` of an error thrown during HMR. That's usually not enough so now we also capture the stack trace. Relates to angular/angular-cli#29695. PR Close #60067
kirjs
pushed a commit
that referenced
this pull request
Feb 24, 2025
Currently we send the `message` of an error thrown during HMR. That's usually not enough so now we also capture the stack trace. Relates to angular/angular-cli#29695. PR Close #60067
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we send the
messageof an error thrown during HMR. That's usually not enough so now we also capture the stack trace.Relates to angular/angular-cli#29695.