Skip to content

fix(common): clean up onUrlChange listener when root scope is destroyed #60004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(common): clean up onUrlChange listener when root scope is destroyed #60004

wants to merge 1 commit into from
+4 −1

Conversation

arturovt
Copy link
Contributor

This cleans up the onUrlChange listener once the root scope is destroyed.

@arturovt
fix(common): clean up onUrlChange listener when root scope is destr…

Verified

This commit was signed with the committer’s verified signature. The key has expired.
msrd0
GPG key ID: DCC8C247452E98F9
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
d8e3172 
…oyed

This cleans up the `onUrlChange` listener once the root scope is destroyed.
@pullapprove pullapprove bot requested a review from atscott February 18, 2025 21:44
@angular-robot angular-robot bot added the area: common Issues related to APIs in the @angular/common package label Feb 18, 2025
@ngbot ngbot bot added this to the Backlog milestone Feb 18, 2025
@atscott atscott added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Feb 28, 2025
@mmalerba mmalerba added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Feb 28, 2025
@mmalerba
Copy link
Contributor

caretaker note: potentially risky

mmalerba pushed a commit that referenced this pull request Mar 3, 2025
@arturovt @mmalerba
fix(common): clean up onUrlChange listener when root scope is destr…

Verified

This commit was signed with the committer’s verified signature. The key has expired.
msrd0
GPG key ID: DCC8C247452E98F9
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
c2de5f6 
…oyed (#60004)

This cleans up the `onUrlChange` listener once the root scope is destroyed.

PR Close #60004
@mmalerba
Copy link
Contributor

mmalerba commented Mar 3, 2025

This PR was merged into the repository by commit 36b60a9.

The changes were merged into the following branches: main, 19.2.x

@mmalerba mmalerba closed this in 36b60a9 Mar 3, 2025
@arturovt arturovt deleted the fix/common-upgrade-location-onUrlChange branch March 3, 2025 18:40
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@atscott atscott

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: common Issues related to APIs in the @angular/common package merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arturovt @mmalerba @atscott