Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(router): Allow resolvers to read resolved data from ancestors #59860

Closed
wants to merge 1 commit into from

Conversation

atscott
Copy link
Contributor

@atscott atscott commented Feb 5, 2025

This commit updates the resolver execution to ensure that resolvers in children routes are able to read the resolved data from anything above them in the route tree. Because resolvers on one level block execution of those below, it seems more of an oversight in the initial implementation than anything else that this wasn't already possible.

resolves #47287

This commit updates the resolver execution to ensure that resolvers in
children routes are able to read the resolved data from anything above
them in the route tree. Because resolvers on one level block execution
of those below, it seems more of an oversight in the initial
implementation than anything else that this wasn't already possible.

resolves angular#47287
@atscott atscott added the target: minor This PR is targeted for the next minor release label Feb 5, 2025
@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: router labels Feb 5, 2025
@ngbot ngbot bot added this to the Backlog milestone Feb 5, 2025
@atscott
Copy link
Contributor Author

atscott commented Feb 5, 2025

reviewer note: This has a green TGP though maybe it should still be considered a breaking change? Technically if there was static data with the same key as a resolver in a parent, reading that data in the child resolver would have given you the static value rather than the resolved value from the parent. This seems....technically possible but quite unlikely. I've marked the target as "major" out of caution for this, but maybe it doesn't need a callout in the breaking changes notes.

@atscott atscott added target: major This PR is targeted for the next major release and removed target: minor This PR is targeted for the next minor release labels Feb 5, 2025
@atscott atscott added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note action: merge The PR is ready for merge by the caretaker labels Feb 20, 2025
@kirjs
Copy link
Contributor

kirjs commented Feb 25, 2025

This PR was merged into the repository by commit 7c12cb1.

The changes were merged into the following branches: main

@kirjs kirjs closed this in 7c12cb1 Feb 25, 2025
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: router detected: feature PR contains a feature commit target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make resolved data from parent is available in child resolver
3 participants