fix(platform-browser): prepend baseHref to sourceMappingURL in CSS content
#59730
+161
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
area: core
alan-agius4
force-pushed
the
css-sourcemap-external
branch
3 times, most recently
from
dc9426b to
e9d4ffa
Compare
eneajaho
reviewed
Jan 27, 2025
alan-agius4
force-pushed
the
css-sourcemap-external
branch
2 times, most recently
from
221552d to
5b7c512
Compare
…S content Implemented functionality to prepend the baseHref to `sourceMappingURL` in CSS content. Added handling to ensure external sourcemaps are loaded relative to the baseHref. Corrected sourcemap URL behavior when accessing pages with multi-segment URLs (e.g., `/foo/bar`). Ensured that when the baseHref is set to `/`, maps are requested from the correct path (e.g., `http://localhost/comp.css.map` instead of `http://localhost/foo/bar/comp.css.map`). Closes angular#59729
alan-agius4
force-pushed
the
css-sourcemap-external
branch
from
5b7c512 to
2e90ced
Compare
alan-agius4
added
the
action: review
alan-agius4
force-pushed
the
css-sourcemap-external
branch
2 times, most recently
from
3bb968f to
2e90ced
Compare
clydin
reviewed
Jan 27, 2025
…` in CSS content
alan-agius4
force-pushed
the
css-sourcemap-external
branch
from
94b920c to
1600d37
Compare
…` in CSS content
clydin
approved these changes
Jan 28, 2025
alan-agius4
added
action: merge
|
This PR was merged into the repository by commit 6b09716. The changes were merged into the following branches: main, 19.1.x |
alxhub
pushed a commit
that referenced
this pull request
Jan 29, 2025
…S content (#59730) Implemented functionality to prepend the baseHref to `sourceMappingURL` in CSS content. Added handling to ensure external sourcemaps are loaded relative to the baseHref. Corrected sourcemap URL behavior when accessing pages with multi-segment URLs (e.g., `/foo/bar`). Ensured that when the baseHref is set to `/`, maps are requested from the correct path (e.g., `http://localhost/comp.css.map` instead of `http://localhost/foo/bar/comp.css.map`). Closes #59729 PR Close #59730
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
…S content (angular#59730) Implemented functionality to prepend the baseHref to `sourceMappingURL` in CSS content. Added handling to ensure external sourcemaps are loaded relative to the baseHref. Corrected sourcemap URL behavior when accessing pages with multi-segment URLs (e.g., `/foo/bar`). Ensured that when the baseHref is set to `/`, maps are requested from the correct path (e.g., `http://localhost/comp.css.map` instead of `http://localhost/foo/bar/comp.css.map`). Closes angular#59729 PR Close angular#59730
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented functionality to prepend the baseHref to
sourceMappingURLin CSS content. Added handling to ensure external sourcemaps are loaded relative to the baseHref. Corrected sourcemap URL behavior when accessing pages with multi-segment URLs (e.g.,/foo/bar). Ensured that when the baseHref is set to/, maps are requested from the correct path (e.g.,http://localhost/comp.css.mapinstead ofhttp://localhost/foo/bar/comp.css.map).Closes #59729
//cc @clydin